Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted null check in MobileCoreServices #1455

Merged
merged 1 commit into from
Jan 9, 2017

Conversation

chamons
Copy link
Contributor

@chamons chamons commented Jan 9, 2017

@chamons
Copy link
Contributor Author

chamons commented Jan 9, 2017

History shows @spouliot was person who first added file, so if for some crazy reason this was intended he'd likely know.

@spouliot
Copy link
Contributor

spouliot commented Jan 9, 2017

@chamons typo (mostly likely) or local refactoring (before committing). Please backport for cycle9

@monojenkins
Copy link
Collaborator

Build failure

@chamons
Copy link
Contributor Author

chamons commented Jan 9, 2017

build

@monojenkins
Copy link
Collaborator

Build failure

@chamons
Copy link
Contributor Author

chamons commented Jan 9, 2017

Test failure unrelated (obviously).

@mandel-macaque
Copy link
Member

@chamons I triggered a rebuild, will look at the output to see if we are ok to land it and will ensure that it does not happen again (the unrelated failure).

@monojenkins
Copy link
Collaborator

Build success

@chamons chamons merged commit e33b78f into master Jan 9, 2017
@chamons chamons deleted the mobile_core_flipped_check branch January 9, 2017 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants