[dotnet] Change condition when to include the System.Runtime.InteropServices.NFloat.Internal package reference. #15183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervices.NFloat.Internal package reference. '(BundledNETCorePlatformsPackageVersion' will be 7.0 when building with .NET 7 and using the 'net6.0-*' TFM, but we still need the package reference in that case. So change the condition to go off TargetFrameworkVersion instead.
rolfbjarne
added
not-notes-worthy
|
/sudo backport release/6.0.4xx |
|
Backport Job to branch release/6.0.4xx Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6234029 for more details. |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API diff (for current PR)ℹ️ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)✅ API Diff from stable .NETXamarin vs .NETGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1033.Monterey' |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
dalexsoto
approved these changes
Jun 2, 2022
mandel-macaque
approved these changes
Jun 2, 2022
tj-devel709
approved these changes
Jun 2, 2022
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results19 tests failed, 215 tests passed.Failed tests
Pipeline on Agent XAMBOT-1035.Monterey' |
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2558). |
rolfbjarne
added a commit
that referenced
this pull request
Jun 3, 2022
…m.Runtime.InteropServices.NFloat.Internal package reference. (#15184) 'BundledNETCorePlatformsPackageVersion' will be 7.0 when building with .NET 7 and using the 'net6.0-*' TFM, but we still need the package reference in that case. So change the condition to go off TargetFrameworkVersion instead. Backport of #15183 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Alex Soto <alex@alexsoto.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'BundledNETCorePlatformsPackageVersion' will be 7.0 when building with .NET 7
and using the 'net6.0-*' TFM, but we still need the package reference in that
case. So change the condition to go off TargetFrameworkVersion instead.