Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NearbyInteraction] Bump to support Xcode 14.1 #16338

Merged

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the notes-mention Deserves a mention in release notes label Oct 13, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

#if WATCH
public partial class NISession {

public virtual void SetARSession (ARSession session) => throw new InvalidOperationException (Constants.ApiRemovedGeneral);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need the platform supported attributes probably Obsolete?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I forgot the obsolete. Good catch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MORE!!!

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this is only for watch. Watch is not present on Net, so we do not need to add anything more than the Obsolete for legacy.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS: vsdrops gist (No breaking changes)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS: vsdrops gist (No breaking changes)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1164.Monterey'
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1169.Monterey'
Hash: fae0e5295f9b2b110e15e07815b2e15201c3331f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 9 tests failed, 219 tests passed.

Failures

❌ bcl tests

3 tests failed, 66 tests passed.
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ introspection tests

2 tests failed, 11 tests passed.
  • introspection/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

2 tests failed, 63 tests passed.
  • dont link/iOS Unified 64-bits - simulator/Release [dotnet]: LaunchTimedOut
  • link sdk/iOS Unified 64-bits - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests

2 tests failed, 21 tests passed.
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: LaunchTimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: LaunchTimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

2 tests crashed, 8 tests failed, 154 tests passed.

Failures

❌ bcl tests

2 tests failed, 67 tests passed.
  • mscorlib Part 2/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • mscorlib Part 3/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ interdependent_binding_projects tests

1 tests failed, 6 tests passed.
  • interdependent-binding-projects/tvOS - simulator/Debug [dotnet]: LaunchTimedOut

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

🔥 Failed catastrophically on VSTS: simulator tests - linker (no summary found).

Html Report (VSDrops) Download

❌ mac_binding_project tests

🔥 Failed catastrophically on VSTS: simulator tests - mac_binding_project (no summary found).

Html Report (VSDrops) Download

❌ mononative tests

1 tests failed, 11 tests passed.
  • mono-native-compat/iOS Unified Today Extension 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests

2 tests failed, 21 tests passed.
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): TimedOut

Html Report (VSDrops) Download

❌ mtouch tests

1 tests failed, 0 tests passed.
  • MTouch tests/NUnit: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@mandel-macaque mandel-macaque merged commit 093b5d2 into xamarin:xcode14.1 Oct 17, 2022
@mandel-macaque mandel-macaque deleted the nearbyinteraction-xcode14.1-b3 branch October 17, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants