New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NearbyInteraction] Bump to support Xcode 14.1 #16338
Merged
mandel-macaque
merged 4 commits into
xamarin:xcode14.1
from
mandel-macaque:nearbyinteraction-xcode14.1-b3
Oct 17, 2022
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// | ||
// NICompat.cs | ||
// | ||
// Copyright (C) Microsoft Corporation. All rights reserved. | ||
// | ||
|
||
using System; | ||
using System.ComponentModel; | ||
using System.Threading.Tasks; | ||
using Foundation; | ||
using CoreFoundation; | ||
using ObjCRuntime; | ||
|
||
#if __MACCATALYST__ || !IOS | ||
using ARSession = Foundation.NSObject; | ||
#else | ||
using ARKit; | ||
#endif | ||
|
||
#if NET | ||
using Vector3 = global::System.Numerics.Vector3; | ||
using MatrixFloat4x4 = global::CoreGraphics.NMatrix4; | ||
#else | ||
using NativeHandle = System.IntPtr; | ||
using Vector3 = global::OpenTK.Vector3; | ||
using MatrixFloat4x4 = global::OpenTK.NMatrix4; | ||
#endif | ||
|
||
#nullable enable | ||
namespace NearbyInteraction { | ||
|
||
#if WATCH | ||
public partial class NISession { | ||
|
||
public virtual void SetARSession (ARSession session) => throw new InvalidOperationException (Constants.ApiRemovedGeneral); | ||
|
||
public virtual MatrixFloat4x4 GetWorldTransform (NINearbyObject @object) => throw new InvalidOperationException (Constants.ApiRemovedGeneral); | ||
|
||
} | ||
#endif | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need the platform supported attributes probably Obsolete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I forgot the obsolete. Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MORE!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this is only for watch. Watch is not present on Net, so we do not need to add anything more than the Obsolete for legacy.