[dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… #18567

mauroa · 2023-07-20T16:47:42Z

… the Build Agent and remote tasks

DOTNET_ROOT and DOTNET_HOST_PATH are being deprecated as a mechanism to store the location of dotnet. PATH will be used instead, so we should ensure that the existing code that makes usage of these variables is adapted to the new guidelines. More information:

dotnet/roslyn@f454d69

dotnet/runtime#88754 (comment)

Additionally, to avoid confusion, we are using a dedicate DOTNET_CUSTOM_PATH variable with the path of the dotnet used by the XMA Build Agent, so it can be used internally by the tasks without mixing it with the existing dotnet variables

github-actions · 2023-07-20T16:52:49Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2023-07-20T17:23:18Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dalexsoto

Looks like this is breaking the macOS tests

  Creating directory "obj/Debug/net7.0-macos/macOS/".
         /Users/builder/azdo/_work/_tool/dotnet/dotnet /Users/builder/azdo/_work/3/s/xamarin-macios/builds/downloads/dotnet-sdk-7.0.206-servicing.23254.11/packs/Microsoft.macOS.Sdk/13.3.7351-ci.pr.gh18567/tools/lib/bgen/bgen.dll @/Users/builder/azdo/_work/3/s/xamarin-macios/tests/bindings-test/dotnet/macOS/obj/Debug/net7.0-macos/response-file.rsp 
         It was not possible to find any compatible framework version
         The framework 'Microsoft.NETCore.App', version '7.0.0' was not found.
           - The following frameworks were found:
               5.0.17 at [/Users/builder/azdo/_work/_tool/dotnet/shared/Microsoft.NETCore.App]
         
         You can resolve the problem by installing the specified framework and/or SDK.
         
         The specified framework can be found at:
           - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=7.0.0&arch=x64&rid=osx.11.2-x64
     1>/Users/builder/azdo/_work/3/s/xamarin-macios/builds/downloads/dotnet-sdk-7.0.206-servicing.23254.11/packs/Microsoft.macOS.Sdk/13.3.7351-ci.pr.gh18567/tools/msbuild/macOS/Xamarin.Shared.targets(1736,3): error MSB6006: "dotnet" exited with code 150. [/Users/builder/azdo/_work/3/s/xamarin-macios/tests/bindings-test/dotnet/macOS/bindings-test.csproj]
     1>Done Building Project "/Users/builder/azdo/_work/3/s/xamarin-macios/tests/bindings-test/dotnet/macOS/bindings-test.csproj" (default targets) -- FAILED.
Deferred Messages

… the Build Agent and remote tasks DOTNET_ROOT and DOTNET_HOST_PATH are being deprecated as a mechanism to store the location of dotnet. PATH will be used instead, so we should ensure that the existing code that makes usage of these variables is adapted to the new guidelines. More information: dotnet/roslyn@f454d69 dotnet/runtime#88754 (comment) Additionally, to avoid confusion, we are using a dedicate DOTNET_CUSTOM_PATH variable with the path of the dotnet used by the XMA Build Agent, so it can be used internally by the tasks without mixing it with the existing dotnet variables

github-actions · 2023-07-26T18:52:51Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2023-07-26T20:28:51Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-07-26T20:30:42Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-07-26T20:31:33Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2ce362add18ffb5ef9fd06f5acdc28f7b0aec957 [PR build]

vs-mobiletools-engineering-service2 · 2023-07-26T20:39:30Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-07-26T21:03:35Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 2ce362add18ffb5ef9fd06f5acdc28f7b0aec957 [PR build]

dalexsoto · 2023-07-26T21:12:01Z

/sudo backport net8.0

dalexsoto · 2023-07-26T21:12:29Z

/sudo backport release/8.0.1xx-preview7

vs-mobiletools-engineering-service2 · 2023-07-26T21:12:41Z

Backport Job to branch net8.0 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-07-26T21:13:06Z

Backport Job to branch release/8.0.1xx-preview7 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-07-26T21:14:21Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8153356 for more details.

vs-mobiletools-engineering-service2 · 2023-07-26T21:14:47Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8153360 for more details.

vs-mobiletools-engineering-service2 · 2023-07-26T23:58:59Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 35 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2ce362add18ffb5ef9fd06f5acdc28f7b0aec957 [PR build]

…OOT and DOTNET_HOST_PATH in. (#18591) . the Build Agent and remote tasks DOTNET_ROOT and DOTNET_HOST_PATH are being deprecated as a mechanism to store the location of dotnet. PATH will be used instead, so we should ensure that the existing code that makes usage of these variables is adapted to the new guidelines. More information: dotnet/roslyn@f454d69 dotnet/runtime#88754 (comment) Additionally, to avoid confusion, we are using a dedicate DOTNET_CUSTOM_PATH variable with the path of the dotnet used by the XMA Build Agent, so it can be used internally by the tasks without mixing it with the existing dotnet variables Backport of #18567 --------- Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com> Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>

…T_PATH in. (#18590) . the Build Agent and remote tasks DOTNET_ROOT and DOTNET_HOST_PATH are being deprecated as a mechanism to store the location of dotnet. PATH will be used instead, so we should ensure that the existing code that makes usage of these variables is adapted to the new guidelines. More information: dotnet/roslyn@f454d69 dotnet/runtime#88754 (comment) Additionally, to avoid confusion, we are using a dedicate DOTNET_CUSTOM_PATH variable with the path of the dotnet used by the XMA Build Agent, so it can be used internally by the tasks without mixing it with the existing dotnet variables Backport of #18567 --------- Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com> Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>

mauroa added the not-notes-worthy Ignore for release notes label Jul 20, 2023

mauroa requested review from dalexsoto and mandel-macaque July 20, 2023 16:47

mauroa self-assigned this Jul 20, 2023

mauroa requested review from emaf and rolfbjarne as code owners July 20, 2023 16:47

mauroa marked this pull request as draft July 20, 2023 16:47

mauroa force-pushed the dev/mag/main branch from 6232e1a to 3ba8557 Compare July 20, 2023 17:18

This comment has been minimized.

Sign in to view

mauroa marked this pull request as ready for review July 20, 2023 19:26

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jul 20, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto requested changes Jul 23, 2023

View reviewed changes

mauroa force-pushed the dev/mag/main branch from 930cc62 to e8ec375 Compare July 26, 2023 18:48

Auto-format source code

2ce362a

vs-mobiletools-engineering-service2 mentioned this pull request Jul 26, 2023

[net8.0] [dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in. #18590

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Jul 26, 2023

[release/8.0.1xx-preview7] [dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in. #18591

Merged

dalexsoto approved these changes Jul 26, 2023

View reviewed changes

dalexsoto merged commit 403d017 into main Jul 27, 2023
75 checks passed

dalexsoto deleted the dev/mag/main branch July 27, 2023 00:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… #18567

[dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… #18567

mauroa commented Jul 20, 2023

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 20, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

github-actions bot commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

dalexsoto commented Jul 26, 2023

dalexsoto commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

[dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… #18567

[dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… #18567

Conversation

mauroa commented Jul 20, 2023

github-actions bot commented Jul 20, 2023

⚠️ Your code has been reformatted. ⚠️

github-actions bot commented Jul 20, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 26, 2023

⚠️ Your code has been reformatted. ⚠️

vs-mobiletools-engineering-service2 commented Jul 26, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Jul 26, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jul 26, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jul 26, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Jul 26, 2023

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

✅ Generator diff

dalexsoto commented Jul 26, 2023

dalexsoto commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

vs-mobiletools-engineering-service2 commented Jul 26, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts