Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… #18567

Merged
merged 2 commits into from Jul 27, 2023
Merged

[dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… #18567

merged 2 commits into from Jul 27, 2023

Commits on Jul 26, 2023

  1. [dotnet][xma] Ensure we don't use DOTNET_ROOT and DOTNET_HOST_PATH in… 

    … the Build Agent and remote tasks

DOTNET_ROOT and DOTNET_HOST_PATH are being deprecated as a mechanism to store the location of dotnet. PATH will be used instead, so we should ensure that the existing code that makes usage of these variables is adapted to the new guidelines.
More information:

dotnet/roslyn@f454d69

dotnet/runtime#88754 (comment)

Additionally, to avoid confusion, we are using a dedicate DOTNET_CUSTOM_PATH variable with the path of the dotnet used by the XMA Build Agent, so it can be used internally by the tasks without mixing it with the existing dotnet variables
    @mauroa
    mauroa committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e8ec375 View commit details
    Browse the repository at this point in the history

  2. Auto-format source code

    GitHub Actions Autoformatter committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2ce362a View commit details
    Browse the repository at this point in the history