[release/7.0.3xx] [msbuild] Re-aot referencing assemblies. Fixes #17708. #18654
Conversation
If an assembly changes, then we must AOT compile that assembly again (which we already did), in addition to any assembly that references the modified assembly (which we didn't do). So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency tracking is too complicated for MSBuild to resolve), and instead move the logic to detect if an assembly must be AOT-compiled again into the AOTCompile task. Fixes xamarin#17708.
vs-mobiletools-engineering-service2
requested review from
rolfbjarne,
emaf and
mauroa
as code owners
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2688). |
|
@rolfbjarne wait a little on merging this, the token we use to upload to dotnet7 expired and it is being renewed I wan to use this PR to check all is good |
Yes, my plan was to wait for a while, I just created the PR to see if it passed the tests. |
|
@rolfbjarne feel free to merge this whenever |
…r-18509-to-release/7.0.3xx
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 76 tests passed. Failures❌ dotnettests tests
Html Report (VSDrops) Download Successes
Pipeline on Agent |
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2688). |
If an assembly changes, then we must AOT compile that assembly again (which we already
did), in addition to any assembly that references the modified assembly (which we
didn't do).
So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency
tracking is too complicated for MSBuild to resolve), and instead move the logic to
detect if an assembly must be AOT-compiled again into the AOTCompile task.
Note that this PR has a custom port to .NET 8: #18518.
Fixes #17708.
Backport of #18509