Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0.3xx] [msbuild] Re-aot referencing assemblies. Fixes #17708. #18654

Merged
merged 5 commits into from
Sep 13, 2023
Merged

[release/7.0.3xx] [msbuild] Re-aot referencing assemblies. Fixes #17708. #18654

merged 5 commits into from
Sep 13, 2023

Commits on Aug 7, 2023

  1. [msbuild] Re-aot referencing assemblies. Fixes xamarin#17708. 

    If an assembly changes, then we must AOT compile that assembly again (which we already
did), in addition to any assembly that references the modified assembly (which we
didn't do).

So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency
tracking is too complicated for MSBuild to resolve), and instead move the logic to
detect if an assembly must be AOT-compiled again into the AOTCompile task.

Fixes xamarin#17708.
    @rolfbjarne
    rolfbjarne authored and vs-mobiletools-engineering-service2 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    661bd2e View commit details
    Browse the repository at this point in the history

  2. Auto-format source code

    GitHub Actions Autoformatter authored and vs-mobiletools-engineering-service2 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    77240a5 View commit details
    Browse the repository at this point in the history

  3. Fix indexing issue.

    @rolfbjarne
    rolfbjarne authored and vs-mobiletools-engineering-service2 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3f43b02 View commit details
    Browse the repository at this point in the history

  4. [tests] Don't run an arm64 binary unless we're on an arm64 machine.

    @rolfbjarne
    rolfbjarne authored and vs-mobiletools-engineering-service2 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ea968cd View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Merge remote-tracking branch 'origin/release/7.0.3xx' into backport-p… 

    …r-18509-to-release/7.0.3xx
    @rolfbjarne
    rolfbjarne committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6f7d366 View commit details
    Browse the repository at this point in the history