[Foundation/UIKit] Provide LoadObject[s] methods that return the expected type in the callback. Fixes #59049. #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…cted type in the callback. Fixes #59049. The callback for these LoadObject[s] methods take an INSItemProviderReading parameter. This tells our runtime that we must provide an instance of a managed object that implements this interface (but nothing else), so we create a `NSItemProviderReadingWrapper` instance, which complies with the API (since the wrapper type implements the corresponding interface). Unfortunately these methods are supposed to return an instance of the passed- in type, so in order to comply with this soft (documentation-only) requirement, provide a wrapper method that creates instances of the right types. https://bugzilla.xamarin.com/show_bug.cgi?id=59049
rolfbjarne
force-pushed
the
bug59049
branch
from
0ac27f8
to
dc5ff1a
Compare
|
Build failure |
spouliot
approved these changes
Sep 11, 2017
|
❤️ much nicer API |
|
Build failure |
VincentDondain
approved these changes
Sep 11, 2017
|
@timrisi I don't have my High Sierra machine with me today can you try it with yours? |
|
Turns out both samples from the bug are iOS samples, so I was able to test both (and they work). |
|
Build failure |
|
build |
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback for these LoadObject[s] methods take an INSItemProviderReading parameter. This tells our runtime that we must provide an instance of a managed object that implements this interface (but nothing else), so we create a
NSItemProviderReadingWrapperinstance, which complies with the API (since the wrapper type implements the corresponding interface).Unfortunately these methods are supposed to return an instance of the passed-in type, so in order to comply with this soft (documentation-only) requirement, provide a wrapper method that creates instances of the right types.
https://bugzilla.xamarin.com/show_bug.cgi?id=59049