[xtro] Split results by framework and add an HTML report #3093
Conversation
|
don't merge -> old data/comments files needs to be migrated. |
|
Build failure |
|
Build failure |
…to track our differences)
…e it's sown as a build error, not a test error)
|
Build success |
|
Build success |
| static class Log { | ||
| static Dictionary<string, List<string>> lists = new Dictionary<string, List<string>> (); | ||
|
|
||
| public static IList<string> On (string fx) |
There was a problem hiding this comment.
Interesting name :P
| Console.WriteLine ("!unknown-native-enum! {0} bound", extra.Key); | ||
| var t = extra.Value; | ||
| if (!IsNative (t)) | ||
| continue; |
There was a problem hiding this comment.
Not sure why you went for a continue here.
I find:
if (IsNative (t)) {
var framework = Helpers.GetFramework (t);
Log.On (framework).Add ($"!unknown-native-enum! {extra.Key} bound");
}
simpler, more clear.
There was a problem hiding this comment.
less nesting / horizontal scrolling ;-)
not that it makes a big difference in that specific case
tests/xtro-sharpie/Log.cs
Outdated
| var data = File.ReadAllLines (file); | ||
| // TODO: only process lines starting with '!' | ||
| foreach (var line in data) | ||
| list.Remove (line); |
There was a problem hiding this comment.
if (line.StartsWith ("!")) and remove TODO?
There was a problem hiding this comment.
but then I won't have anything to do ? ;-)
| @@ -5,13 +5,14 @@ include $(TOP)/Make.config | |||
| # a 64bits mono is required because of the clang requirement | |||
| MONO ?= mono64 --debug | |||
|
|
|||
| all-local:: run-ios run-osx run-watchos run-tvos classify | |||
| all-local:: | |||
There was a problem hiding this comment.
Is this needed if empty?
There was a problem hiding this comment.
yes, makes make == make all
tests/xtro-sharpie/Makefile
Outdated
| report-short: | ||
| JENKINS_SERVER_COOKIE=1 make report | ||
|
|
||
| all: build $(XIOS_PCH) $(XWATCHOS_PCH) $(XTVOS_PCH) $(XMAC_PCH) |
There was a problem hiding this comment.
Shouldn't that be the first command in the Makefile so when we do a make it's equivalent to make all?
There was a problem hiding this comment.
make is already equal to make all - but not because of the order (rules are more complex)
…*not* _yet_ been migrated.
|
Build success |
|
Build success |
|
Build failure |
spouliot
added
run-xtro-tests
|
Build failure |
|
Build failure |
|
Build failure |
|
Build failure |
|
Build failure |
|
Build failure |
|
Build failure |
|
build |
|
Build failure |
|
build |
|
Build success |
|
running |
spouliot
changed the title
|
Build failure |
|
known, random failure -> https://github.com/xamarin/maccore/issues/592 |
| var count = ProcessFile (filename); | ||
| log.Write ("<td align='center'"); | ||
| if (count < 1) | ||
| log.Write (" bgcolor='salmon'>-"); |
There was a problem hiding this comment.
glad it did not went unnoticed ;-)
and now we can say there's something fishy about that PR :-)
No description provided.