Add NullAllowed for GetContentSizeForFrame and GetFrameSizeForContent parameters #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters From https://developer.apple.com/documentation/appkit/nsscrollview/1403471-contentsizeforframesize: > horizontalScrollerClass: The class used as the horizontal scroller. A value of nil specifies that no horizontal scroller is used.
chamons
approved these changes
Aug 28, 2018
|
These changes looks straightforward and correct. I'll take a look at test results when they come up, any errors are likely intermittent test failures. Thanks for your contribution! 🎉 |
spouliot
approved these changes
Aug 28, 2018
|
build |
VincentDondain
approved these changes
Aug 28, 2018
|
Build failure Test results4 tests failed, 0 tests skipped, 76 tests passed.Failed tests
|
rolfbjarne
approved these changes
Aug 29, 2018
dalexsoto
approved these changes
Aug 29, 2018
|
Not sure if timeout is https://github.com/xamarin/maccore/issues/957 or https://github.com/xamarin/maccore/issues/965 but it isn't related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://developer.apple.com/documentation/appkit/nsscrollview/1403471-contentsizeforframesize: