[tests] Add MONO_SDK_DESTDIR to config file when using system XI for tests. #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests.
Fixes this problem when running the VSTS device tests:
Unhandled Exception:
System.Collections.Generic.KeyNotFoundException: The given key 'MONO_SDK_DESTDIR' was not present in the dictionary.
at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) [0x0001e] in <96207d0baa204f48a53ad6be05f5ecba>:0
at xharness.Harness.LoadConfig () [0x001a3] in <299e29e4a95f41499aef8f7d9863ca3d>:0
at xharness.Harness.Execute () [0x00001] in <299e29e4a95f41499aef8f7d9863ca3d>:0
at xharness.MainClass.Main (System.String[] args) [0x003e3] in <299e29e4a95f41499aef8f7d9863ca3d>:0
spouliot
approved these changes
Jan 8, 2019
|
Build failure |
|
build |
VincentDondain
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Cool thanks, fixes https://github.com/xamarin/maccore/issues/1319
dalexsoto
approved these changes
Jan 8, 2019
chamons
approved these changes
Jan 8, 2019
|
Build failure |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jan 9, 2019
…nexpectedly changed.
Fixes this problem:
The following files were modified, and they shouldn't have been:
/Users/builder/jenkins/workspace/xamarin-macios-pr-builder/src
which shouldn't be reported, since the "file" in question is a directory.
Reference: xamarin#5355 (comment)
|
API/generator diff failure is unrelated (will be fixed with #5360). |
rolfbjarne
added a commit
that referenced
this pull request
Jan 9, 2019
…nexpectedly changed. (#5360) Fixes this problem: The following files were modified, and they shouldn't have been: /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/src which shouldn't be reported, since the "file" in question is a directory. Reference: #5355 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this problem when running the VSTS device tests:
Fixes https://github.com/xamarin/maccore/issues/1319.