[Security] Fix bug 44062 - SecRecord is missing a property to enable password access control #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…password access control https://bugzilla.xamarin.com/show_bug.cgi?id=44062 Added missing kSecUseAuthenticationContext to our SecRecord wrapper
|
Build success |
spouliot
reviewed
Sep 16, 2016
| } | ||
| set { | ||
| if (value == null) | ||
| throw new ArgumentNullException (nameof (value)); |
There was a problem hiding this comment.
so it's not something you can set to null ?
There was a problem hiding this comment.
No according to the tests I did, while it does not crash the API, it just won't do what you expect it to do
rolfbjarne
approved these changes
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.xamarin.com/show_bug.cgi?id=44062
Added missing kSecUseAuthenticationContext to our SecRecord wrapper