[metrickit] Update for Xcode 12 beta 2 #9151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitneyschmidt
approved these changes
Jul 21, 2020
|
Build success |
rolfbjarne
requested changes
Jul 22, 2020
|
|
||
| public virtual NSDictionary DictionaryRepresentation { | ||
| get { | ||
| if (PlatformHelper.CheckSystemVersion (14,0)) |
There was a problem hiding this comment.
This version check doesn't work on macOS nor watchOS. This framework might not be on neither platform right now, but I think we should consider the possibility that it might be in the future, and do something like:
Suggested change
| if (PlatformHelper.CheckSystemVersion (14,0)) | |
| #if __IOS__ | |
| if (PlatformHelper.CheckSystemVersion (14, 0)) | |
| #else | |
| #error Platform-specific logic not implemented | |
| #endif |
There was a problem hiding this comment.
It's an iOS only framework but it can't hurt :)
|
|
||
| public virtual NSDictionary DictionaryRepresentation { | ||
| get { | ||
| if (PlatformHelper.CheckSystemVersion (14,0)) |
|
|
||
| public virtual NSDictionary DictionaryRepresentation { | ||
| get { | ||
| if (PlatformHelper.CheckSystemVersion (14,0)) |
rolfbjarne
approved these changes
Jul 22, 2020
mandel-macaque
approved these changes
Jul 22, 2020
|
Build success |
dalexsoto
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.