Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Notifications API #36

Closed
Stupremee opened this issue Sep 20, 2020 · 2 comments · Fixed by #38
Closed

Add Notifications API #36

Stupremee opened this issue Sep 20, 2020 · 2 comments · Fixed by #38

Comments

@Stupremee
Copy link
Contributor

Add API for notifications
@Stupremee
Copy link
Contributor Author

Stupremee commented Sep 20, 2020 •
edited
Loading

I would also like to implement this 👍

@XAMPPRocky
Copy link
Owner

XAMPPRocky commented Sep 21, 2020 •
edited
Loading

Thank you for your issue! I would be happy to review a PR implementing it. I would recommend also looking at the octokit API docs, as octocrab is heavily inspired from octokit, and I would want octocrab to share a similar structure. https://octokit.github.io/rest.js/v18

@Stupremee Stupremee mentioned this issue Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement notification API
2 participants
@XAMPPRocky @Stupremee