Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer] - Better fail checks #7

Open
xan1242 opened this issue Aug 21, 2022 · 4 comments
Open

[Installer] - Better fail checks #7

xan1242 opened this issue Aug 21, 2022 · 4 comments
Labels
enhancement New feature or request installer Bug related to installer wontfix This will not be worked on

Comments

@xan1242
Copy link
Owner

xan1242 commented Aug 21, 2022

Installer does NOT work under Wine/Proton because the work directory is wrong.

Secondly, the installer says it succeeded even though it clearly failed because of this.

@xan1242
Copy link
Owner Author

xan1242 commented Aug 21, 2022

So this actually seems to be an issue with Wine's command interpreter.

For a 'for' loop, it doesn't accept paths in quotation marks as an argument and it fails instantly. On Windows this works just fine.

for %%f in ("InteractiveMusic/*.asf") won't do anything

for %%f in (InteractiveMusic/*.asf) will work

This is very janky anyways and it needs a better way to call the process (instead of issuing the system command) but I guess this will have to do for now.

(I guess this will have to be noted in a Wine bug report if it hadn't been done already)

@xan1242
Copy link
Owner Author

xan1242 commented Aug 21, 2022

For MW it was fixed in d22a65e

Carbon is next...

@xan1242 xan1242 changed the title [Installer] - Work directory is wrong under Wine/Proton + Better fail checks [Installer] - Better fail checks Aug 21, 2022
@xan1242
Copy link
Owner Author

xan1242 commented Aug 21, 2022

Carbon issues fixed in b7d8535

Next would be to implement better error checks.

@xan1242 xan1242 added installer Bug related to installer enhancement New feature or request labels Aug 21, 2022
@xan1242
Copy link
Owner Author

xan1242 commented Dec 12, 2022

Halting this issue until this is resolved: #15

Considering the removal of interactive music means removal of the installer.

@xan1242 xan1242 added the wontfix This will not be worked on label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request installer Bug related to installer wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant