Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS download (4.2.1) doesn't contain a version number #210

Open
suschizu opened this issue Jan 21, 2021 · 3 comments
Open

MacOS download (4.2.1) doesn't contain a version number #210

suschizu opened this issue Jan 21, 2021 · 3 comments
Labels

Comments

@suschizu
Copy link

Describe the bug
The macOS binary download doesn't contain any version number (its empty)
(https://github.com/xaos-project/XaoS/releases/download/release-4.2.1/XaoS-4.2.1.dmg)

the BundleVersion and ShortVersionString keys are missing in the info.plist
should look like that:

	<key>CFBundleShortVersionString</key>
	<string>4.9.15</string>
…
	<key>CFBundleVersion</key>
	<string>4.9.15</string>

Bildschirmfoto 2021-01-21 um 20 16 22

Desktop (please complete the following information):

  • Version 4.2.1
@kovzol
Copy link
Contributor

kovzol commented Jan 21, 2021

Thanks for your bug report! The .dmg file is automatically created by the macdeployqt application from Qt, we don't add or change anything after it finishes. Maybe it has an issue you encountered.

@kovzol
Copy link
Contributor

kovzol commented Jan 21, 2021

Hm, this seems helpful: http://www.edenwaith.com/blog/index.php?p=125

@vitorgalvao
Copy link

The seems to be a problem in general when building Qt apps.

See #223 for a way to add the version numbers after the app is built (simple enough that it could be added to the built script).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants