[477 idl part2] sharable flag, SR.create and SR.attach API change #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plumb through uuid Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
For this to work the GFS2 SR will need to implement Volume.set, and retrieving the 'keys' field. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
This was referenced Feb 6, 2018
gaborigloi
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the SMAPIv3 interface change from
feature/REQ477/master,has to be merged together with these PRs:
xapi-project/sm-cli#26
xapi-project/xapi-storage#70
xapi-project/xcp-idl#202
xapi-project/xen-api#3433
The sharable flag is explained in the xcp-idl commit: xapi-project/xcp-idl@c8bfaf9
The activated on exception/redirection is explained here (SMAPIv3 can require snapshots to be taken on the host that has the VM running, instead of the master): xapi-project/xen-api@620acd2
SMAPIv3:
SR.createandSR.attachneed an uuid parameter too, this is a breaking API change, the xapi PR updates XAPI accordingly.