[477 idl part2] SR.create API change and sharable flag #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
SMAPIv3 backends need to know whether the VDI is sharable. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
This update_vdis function is called from places like SR.scan and VDI.update. Now that we have SMAPIv3 plugins that are not backed by the database, xapi really needs to check the returned vdi_info records and update the database if necessary. Previously the SMAPIv1 plugins updated xapi's database, so the whole code in update_vdis did nothing. But now with SMAPIv3 plugins, we have to ensure that we propagate the information from the vdi_info records returned by the SM layer into the database, because it may not be in the database, and it may be different from what's in the database. This change does not break SMAPIv1 plugins, because the vdi_info_of_vdi_rec function in storage_access.ml fetches the correct VDI.sharable field from xapi's database, so in case of SMAPIv1 plugins, this should be a no-op. This vdi_info_of_vdi_rec is the function we use in SR.scan and VDI.stat in our SMAPIv1<->SMAPIv2 translator in storage_access.ml to return a list of vdi_info's, or a single vdi_info, respectively, from xapi's database. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
This was referenced Feb 6, 2018
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
…nfig after SR.create Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
gaborigloi
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the SMAPIv3 interface change from
feature/REQ477/masterbranch.Also expose the
sharablefield to SMAPIv3 (required for the HA statefile and redolog), internally XAPI already tracked this field. SMAPIv1 looked insm-configto find this out, no change there.This PR needs to be merged together with these ones otherwise the build breaks:
xapi-project/sm-cli#26
xapi-project/xapi-storage#70
xapi-project/xapi-storage-script#56
xapi-project/xcp-idl#202
Build on internal branch
private/edvint/477-idl-part2. Thefeature/REQ477/masterbranch that these commits were part of had 2 full nightlies run on it, please let me know what kind of tests should be run on these reduced set of changes.