Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[447 idl part2] CP-24350: plumb through sharable flag #26

Merged
merged 1 commit into from
Feb 8, 2018
Merged

[447 idl part2] CP-24350: plumb through sharable flag #26

merged 1 commit into from
Feb 8, 2018

Conversation

edwintorok
Copy link
Contributor

@edwintorok edwintorok commented Feb 6, 2018

This is part of the SMAPIv3 interface change from feature/REQ477/master,
has to be merged together with these PRs:
xapi-project/xen-api#3433
xapi-project/xapi-storage#70
xapi-project/xapi-storage-script#56
xapi-project/xcp-idl#202

The sharable flag is explained in the xcp-idl commit: xapi-project/xcp-idl@c8bfaf9

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid. I would have preferred when some of the long lines were broken up because long lines are cumbersome during merge conflict resolution and whenever we want to print something. But this doesn't need fixing now.

@edwintorok
Copy link
Contributor Author

Thanks, I'll keep that in mind for future changes to this repo.

@edwintorok edwintorok merged commit bcf8e27 into xapi-project:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants