Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These do not convert to epoll, but instead:
threads.posix
already or not)There are a few more commits like this (e.g. replace one
proxy
function with another, or replace oneDelay
module with another, but I'd rather do more testing on those, even if they are seemingly low risk / correct).For now
feature/perf
has already accumulated quite a few changes, that we should probably test + merge before putting moreepoll
content in (and then when we add epoll those same tests should still pass).Draft PR, waiting on a BVT just in case.