Low risk Unix.select changes #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Woods <steven.woods@citrix.com>
This is a followup of this commit: 14fd0c9 ("CA-226177: Fix premature termination of cli") That commit dropped the active monitoring of stunnel processes, but kept the while-select loop. That loop serves no purpose now, we can instead do a blocking Unix.read directly, and get woken up when a packet arrives (this is the the single-threaded CLI, not the CLI server). Signed-off-by: Edwin Török <edwin.torok@cloud.com>
lindig
approved these changes
May 21, 2024
psafont
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These do not convert to epoll, but instead:
threads.posixalready or not)There are a few more commits like this (e.g. replace one
proxyfunction with another, or replace oneDelaymodule with another, but I'd rather do more testing on those, even if they are seemingly low risk / correct).For now
feature/perfhas already accumulated quite a few changes, that we should probably test + merge before putting moreepollcontent in (and then when we add epoll those same tests should still pass).Draft PR, waiting on a BVT just in case.