Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low risk Unix.select changes #5640

Merged

Commits on May 20, 2024

  1. CP-32622: Use Unix.sleepf for sleeps instead of select

    Signed-off-by: Steven Woods <steven.woods@citrix.com>
    snwoods authored and edwintorok committed May 20, 2024
    Configuration menu
    Copy the full SHA
    374b5dc View commit details
    Browse the repository at this point in the history
  2. CP-47536: drop Unix.select in newcli

    This is a followup of this commit:
    14fd0c9 ("CA-226177: Fix premature termination of cli")
    
    That commit dropped the active monitoring of stunnel processes,
    but kept the while-select loop.
    That loop serves no purpose now, we can instead do a blocking Unix.read directly,
    and get woken up when a packet arrives (this is the the single-threaded CLI, not the CLI server).
    
    Signed-off-by: Edwin Török <edwin.torok@cloud.com>
    edwintorok committed May 20, 2024
    Configuration menu
    Copy the full SHA
    760641f View commit details
    Browse the repository at this point in the history