Delete trigger and trigger function on add column operation rollback #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Jul 19, 2023
|
It feels like trigger handling will require some common helpers so they can be used across the board |
Extract the `triggerFunctionName` function so that the `Rollback` method can use it to delete the function. Deleting the function with `CASCADE` deletes the trigger that invokes the function too.
Ensure that the trigger function and trigger are removed when an add column operation (that specifies `up` SQL) is removed.
andrew-farries
force-pushed
the
delete-trigger-on-add-col-rollback
branch
from
de076f9
to
f9e141f
Compare
andrew-farries
added a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
upSQL in add column operations was added in #34When such an add column operation runs, a trigger (and therefore a trigger function) is created to implement running
upSQL on insertions to the old schema.This PR ensures that the trigger and function are dropped when the migration is rolled back:
afterRollbackhook to the existing test forupSQL.