Make index name mandatory on create index operation #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Aug 18, 2023
This was referenced Sep 14, 2023
andrew-farries
added a commit
that referenced
this pull request
Sep 14, 2023
Make it required to supply a name for the `CHECK` constraint when adding one with the `set_check_constraint` operation. It should be possible to drop constraints with a later migration (not yet implemented), so requiring a name and not relying on automatic generation of constraint names will make this easier. The same thing was done for indexes in #59
andrew-farries
added a commit
that referenced
this pull request
Sep 15, 2023
Make it required to supply a name for a foreign key constraint created in either the `create_table`, `add_column` or `set_foreign_key` operations. It should be possible to drop constraints with a later migration (not yet implemented), so requiring a name and not relying on automatic generation of constraint names will make this easier. The same thing was done for indexes in #59 and `CHECK` constraints in #99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make specifying a name mandatory on the Create index operation.
In order to work with indexes in subsequent migrations (eg deleting the index), the user will have to know the name of the migration. If the migration name is auto-generated and we ever change how names are generated, then we risk breaking a user's migrations if they have migrations that refer to these generated names.