Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

RuntimeAction content assist should match Action name #9

Closed
gdaniel opened this issue Oct 25, 2018 · 1 comment
Closed

RuntimeAction content assist should match Action name #9

gdaniel opened this issue Oct 25, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gdaniel
Copy link
Member

gdaniel commented Oct 25, 2018

The current implementation of the content assist matches the Platform name qualifying the action (see xatkit-bot-platform/xatkit-runtime#118). This could be improved by matching both the Platform name and the name of the Action, that is typically entered by the user.
Matching only Platform name does not provide a very useful content assist: all the actions from the Platform are matched, and the user needs to enter the full name of the Platform plus the beginning of the Action name to have a real match.

@gdaniel gdaniel self-assigned this Oct 25, 2018
gdaniel referenced this issue in xatkit-bot-platform/xatkit-runtime Oct 25, 2018
This fixes changes how Action are referenced in the Orchestration DSL: instead of qualifying the duplicated actions we chose to qualify all the actions, in order to keep the DSL clean and easy to understand. 
Note that the content assist matches actions by their module first, which is not optimal (refs #163)
@gdaniel gdaniel changed the title ActionInstance content assist should match Action name RuntimeAction content assist should match Action name Nov 19, 2018
@gdaniel gdaniel transferred this issue from xatkit-bot-platform/xatkit-runtime Aug 18, 2019
@gdaniel gdaniel added the enhancement New feature or request label Aug 18, 2019
@gdaniel
Copy link
Member Author

gdaniel commented Nov 12, 2019

Fixed with Xbase integration, the completion is performed as for a Java static method.

@gdaniel gdaniel closed this as completed Nov 12, 2019
@gdaniel gdaniel added this to the Next Release milestone Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant