Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Add pipeline for image processing - also may solve memory issue #28

Open
janvarev opened this issue Jun 9, 2023 · 2 comments
Open

Add pipeline for image processing - also may solve memory issue #28

janvarev opened this issue Jun 9, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@janvarev
Copy link

janvarev commented Jun 9, 2023

Hi!

It may be good to add pipeline to image processing - for example, to use upscaler/face restorer after img making.

As an example, you can use this stuff: https://github.com/janvarev/chain-img-processor - there are framework, where pipeline stages adjusted as a separate plugins.

I've already implemented codeformer upscale/face restore, so it may be good to implement it in this project too.

There are two options to implement it:

  • You can use ChainImgProcessor, and just replace img processing stuff, adding pipeline at end.
  • Or you can use ChainVideoProcessor - it uses Richard's code, and effectively process video through pipeline in several threads WITHOUT need to load all frames to memory (I saw that there are problems with that Out of memory error when refacing #18 )
@xaviviro xaviviro added the enhancement New feature or request label Jun 9, 2023
@xaviviro
Copy link
Owner

xaviviro commented Jun 9, 2023

That's a great idea, it could have a lot of potential! I really appreciate the suggestion. It occurs to me that I could design it in such a way that more tools could be chained for pre-processing or post-processing.

Thnks!!!

@janvarev
Copy link
Author

janvarev commented Jul 3, 2023

Just the notice - we increase number of plugins, so if you'll switch to this architecture, plugins for codeformer, gfpgan, gfpganonnx enchancement will be available (from https://github.com/RichardErkhov/Richard-roop )
(gfpganonnx near 10x faster then codeformer)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants