Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkAuthenticate() need to return value #43

Closed
wu-yuanhui opened this issue Jan 23, 2018 · 1 comment
Closed

checkAuthenticate() need to return value #43

wu-yuanhui opened this issue Jan 23, 2018 · 1 comment

Comments

@wu-yuanhui
Copy link

Hello, my english is very pool, please understand.

In Cas/src/Xavrsl/Cas/Sso.php near line 161, there is a method named checkAuthenticate(),
it call the phpCAS::checkAuthentication() method, and the phpCAS::checkAuthentication() will return true or false. So, i think Sso need to return the value too. Like this:

···php

public function checkAuthenticate()
{
    if($this->isPretending()) return true;
    try
    {
        // phpCAS::checkAuthentication();                        <====this line need to return value.
        return phpCAS::checkAuthentication();
    }
    catch(\Exception $e)
    {
        throw new CasAuthenticationException;
    }
}

Please fix it as soon as possible, thinks, thinks, thinks.
@XavRsl
Copy link
Owner

XavRsl commented Jan 23, 2018

I haven't used that package for a while and it's not really maintained anymore... I encourage you to use https://github.com/subfission/cas instead as it is originally a fork of my package but maintained.

Sorry.

Xavier

@XavRsl XavRsl closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants