Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Plurals should be implemented using stringsdict #479

Open
wutschel opened this issue Nov 18, 2021 · 2 comments
Open

Maintenance: Plurals should be implemented using stringsdict #479

wutschel opened this issue Nov 18, 2021 · 2 comments

Comments

@wutschel
Copy link
Collaborator

During reviewing #476 it was mentioned that the way how plurals are treated should be changed to stringsdict.

Example:
NSString *minutesUnit = minutes > 1 ? LOCALIZED_STR(@"Mins.") : LOCALIZED_STR(@"Min");

Strings using this kind of solution:

"1 result" = "1 Ergebnis";
"%d results" = "%d Ergebnisse";
"Songs" = "Lieder";
"Song" = "Lied";
"Mins." = "Min.";
"Min" = "Min";
"vote" = "Bewertung";
"votes" = "Bewertungen";
"Not listened" = "Nicht gehört";
"Listened one time" = "Einmal gehört";
"Listened %@ times" = "%@ mal gehört";
"Not watched" = "Nicht gesehen";
"Watched one time" = "Einmal gesehen";
"Watched %@ times" = "%@ mal gesehen";
@wutschel
Copy link
Collaborator Author

@kambala-decapitator, I am wondering, if the work to make this functioning with Weblate is not too much of effort compared to the benefit. Not too much "bang for the buck".

@kambala-decapitator
Copy link
Collaborator

not a high priority, can be done later. But having proper localisation Is desired I'd say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants