Improvement: Rework handling of timers #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next improvement will be to show icons to differentiate scheduled recordings from reminders. |
|
@ksooo, I hope this way the implementation makes sense now. |
Very nice, thanks a bunch. |
wutschel
force-pushed
the
timer_rules_alt
branch
from
1b3bea3
to
d64e996
Compare
kambala-decapitator
requested changes
Nov 18, 2021
There was a problem hiding this comment.
also we can't merge this before #475 due to touching strings
kambala-decapitator
requested changes
Nov 18, 2021
kambala-decapitator
approved these changes
Nov 18, 2021
wutschel
force-pushed
the
timer_rules_alt
branch
from
c2c297b
to
070343c
Compare
|
Squashed the fixup commits. Will wait for the updated weblate PR now. |
|
please fix conflicts |
TimerDetails are not used by the App. Do not request them.
Use "Timer" instead of "Geplante Aufnahmen". Listed timers and timer rules will also show reminders/alarms, not only scheduled recordings.
wutschel
force-pushed
the
timer_rules_alt
branch
from
070343c
to
357f75f
Compare
|
Rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #444.
This PR implements an separate lists for timer and timer rules. This is still work in progress, so I am keeping this as a draft until this settled.
Details:
istimeruleproperty.Screenshot:
Summary for release notes
Feature: Separate views for timers and timer rules
Improvement: Timer rules show summary, e.g. "Each day from 8:00 PM to 8:15 PM"
Bugfix: Correct German translation around timers