Maintenance: Rework NowPlaying playback states #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kambala-decapitator
approved these changes
May 10, 2024
wutschel
force-pushed
the
rework_playback_states
branch
from
806aba7
to
36f801c
Compare
|
Fixed the comment, squashed and rebased. Let me know how to proceed on the other changes requested. |
- Rename to totalSeconds instead of globalSeconds - Introduce helper methods and defines
Directly use position w/o increasing/decreasing it.
wutschel
force-pushed
the
rework_playback_states
branch
from
3305873
to
6d75462
Compare
|
Squashed and rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the playback states of NowPlaying when receiving the response to
@"Player.GetProperties". Variable names are improved (e.g.canSeekinsteadcanseek), logic is simplified, comments are added, code sections are separated by new lines and existing helper methods are used.Summary for release notes
Maintenance: Rework NowPlaying playback states