Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Rework NowPlaying playback states #1052

Merged
merged 8 commits into from
May 12, 2024
Merged

Maintenance: Rework NowPlaying playback states #1052

merged 8 commits into from
May 12, 2024

Commits on May 11, 2024

  1. Use BOOL for ivar PartyMode

    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    7b9a469 View commit details
    Browse the repository at this point in the history

  2. Rename to canRepeat and refactor

    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    db98b07 View commit details
    Browse the repository at this point in the history

  3. Rename to canShuffle and refactor

    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0f7cc6a View commit details
    Browse the repository at this point in the history

  4. Rename to canSeek and refactor

    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    793b06e View commit details
    Browse the repository at this point in the history

  5. Use getFloatValueFromItem for progress

    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    75f01a4 View commit details
    Browse the repository at this point in the history

  6. Rework time handling in NowPlaying 

    - Rename to totalSeconds instead of globalSeconds
- Introduce helper methods and defines
    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    65131e5 View commit details
    Browse the repository at this point in the history

  7. Rework logic to handle new playlist item playing 

    Directly use position w/o increasing/decreasing it.
    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    c709d9a View commit details
    Browse the repository at this point in the history

  8. Remove unintended disabling of PartyMode button

    @wutschel
    wutschel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    6d75462 View commit details
    Browse the repository at this point in the history