Bugfix: Go back to %d formatting to use existing translations #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression caused by removing compile warning while migrating to iOS 14.
It is not needed to set this default text. The title will be set to the desired state (e.g. "Pull to sync with XBMC...") before shown for the first time.
This was referenced Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing #380 I recognized a regression which was caused when removing compile warnings during the initial iOS 14 migration end of 2020. This caused two texts -- displaying the amount of search results and the amount of "more" items -- not being translated correctly anymore as the related localized strings contain the formatting
"%d". This PR goes back to the old formatting and resolves the warnings through casting toint. As a result the existing translations are again in use.Screenshots (French): https://abload.de/img/bildschirmfoto2021-09kwkad.png
Second change removes a superfluous string which is not needed as the text is overwritten with the desired text for the current state of the pull-down-sync menu when displayed. This allows to remove the related translation for German as well.
Remark: I am not removing the superfluous text strings in the German localized file as this is done as part of the cleanup inside #380.
Summary for release notes
Bugfix: Fix some translations while search and in more items view