Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Rework episode naming #888

Merged
merged 2 commits into from
May 8, 2023

Conversation

wutschel
Copy link
Collaborator

@wutschel wutschel commented May 1, 2023

Description

Fixes an issue reported in this forum post.

Now "SxEy" is used to display season x and episode y consistently and also for the library view (episode view and recently added episodes). The code also got refactored to only implement this once, in a centralized function. This will make it easier to change in case desired.

Screenshots: https://abload.de/img/bildschirmfoto2023-05ajeki.png

Summary for release notes

Improvement: Consistent episode naming (library view, NowPlaying and playlist)

Copy link
Collaborator

@kambala-decapitator kambala-decapitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add leading zero to single digits for a more traditional display style:

  • S01E01
  • S01E10

What do you think?

@wutschel
Copy link
Collaborator Author

wutschel commented May 8, 2023

I would also prefer this, just kept this in sync with how Kodi UI does it.

@kambala-decapitator kambala-decapitator merged commit 83a9664 into xbmc:master May 8, 2023
@wutschel wutschel deleted the rework_episodenaming branch May 8, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants