Fix issue where 1080p means 720p #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the enumeration was not 100% the same in the settings causing 720p to be 640p, and 1080p to be 720p. This fixes xbmc#237
This was referenced May 7, 2019
|
This is the relevant code that is affected by the settings choice. And why it is so important to keep both MAXRESOLUTION and MAXRESOLUTIONSECURE in sync. |
|
very cool, thx @dagwieers ! |
|
@peak3d Not to put any pressure on you, but is there a timeline when to expect this fix in the Kodi repositories? Looking at the feedback we received wrt. 720p not working, and the issues I found that could also be in part related to this issue (or at least troubled users in understanding what is going on), I think we shouldn't hold onto this too long. This impacts the Youtube and Netflix plugins as well, two popular addons. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dagwieers
referenced
this pull request
in CastagnaIT/plugin.video.netflix
Jul 15, 2019
Co-authored-by: Jaker MX <jakermx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the enumeration was not 100% the same in the settings causing 720p to be 640p, and 1080p to be 720p.
This fixes #237 and add-ons/plugin.video.vrt.nu#195