Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outro matching only seems to support one method in the detector #6

Open
razzeee opened this issue Aug 5, 2018 · 2 comments
Open

Outro matching only seems to support one method in the detector #6

razzeee opened this issue Aug 5, 2018 · 2 comments

Comments

@razzeee
Copy link
Member

razzeee commented Aug 5, 2018

No description provided.

@mohit-0212
Copy link
Contributor

This was because outros frames were already very less in the majority of the shows and the second method i.e. 'longest common subsequence' gave even lesser matches as compared to 'all matches'. So didn't make much sense to add the other method.

@razzeee
Copy link
Member Author

razzeee commented Aug 5, 2018

Then we should investigate if we need to keep longest_common match.
It might not be feasible to keep that method around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants