Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broken] - metadata.filmaffinity.com #503

Closed
KarellenX opened this issue Mar 15, 2023 · 8 comments
Closed

[Broken] - metadata.filmaffinity.com #503

KarellenX opened this issue Mar 15, 2023 · 8 comments
Labels

Comments

@KarellenX
Copy link
Member

[Broken] metadata.filmaffinity.com-1.9.5

Add-on details:

Description of changes:

Scraper is broken and unmaintained. See screenshot here... MaDDoGo/metadata.filmaffinity.com#79
I confirm the screenshot.

Please mark as broken in repo.

@romanvm
Copy link

romanvm commented Jul 11, 2023

Do you know in which branch this scraper is located?

@KarellenX
Copy link
Member Author

It seems to be Gotham
https://github.com/xbmc/repo-scrapers/tree/gotham

@KarellenX
Copy link
Member Author

Marked broken with this PR... #520

@MaDDoGo
Copy link

MaDDoGo commented Apr 9, 2024

Hey! I'm trying to fix the issues and re-enable the scrapper. How can this be done @KarellenX? Thanks!

@KarellenX
Copy link
Member Author

@MaDDoGo

You just need to update the scraper for v21 and resubmit to the repo.

But, it would be preferable that the scraper be upgraded to Python 3 as eventually XML scrapers will be deprecated. Not happening immediately, but sometime over the next couple of years.

@romanvm
Copy link

romanvm commented Apr 10, 2024

XML-based scrapers are basically deprecated, maybe not officially but de facto. So if this information provider is still relevant I'd recomment to create a Python-based scraper for it.

@MaDDoGo
Copy link

MaDDoGo commented Apr 10, 2024

I was thinking on doing it in two steps:

  • Reenable it with v1.9.9 release cut yesterday
  • Work on the v2.0.0 based on py scrapping with a temporal solution (and a working addon)

Any guides on how to

  • upgrade to v21
  • migrate from XML to Py versions

Many thanks

@romanvm
Copy link

romanvm commented Apr 10, 2024

XML scrapers have always been an arcane art so I don't know much about them. As for Python scrapers, there are 2 articles in Kodi Wiki with general guidelines about them: https://kodi.wiki/view/Scrapers

And one of the advantages of Python scrapers is that you don't need to deal with regular expressions any more and can use proper HTML parsing libraries or JSON clients to retrieve information from websites or APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants