Remove autotools #10429

notspiff · 2016-09-08T05:16:16Z

This is obviously ahead of its time, but for tracking purposes and for starting to root out possible issues, I have created this PR.

One related question is whether or not you want to relocate the cmake buildsystem to the top of the tree.

akva2 · 2016-09-08T06:49:30Z

can we somehow run a depends based platform using a cmake build on jenkins yet ? curious if there are more shared things between the configures i didn't catch..

fritsch · 2016-09-08T07:03:42Z

We can. I was told cmake builds are the defaults now, so let's try it:

jenkins build this please

hudokkow · 2016-09-08T07:40:43Z

Thanks! CMake relocation is planned. Are you volunteering? 😉

akva2 · 2016-09-08T07:41:45Z

sure. if there is some time still, i dont have many hours to put in these days.

fetzerch · 2016-09-08T21:58:13Z

Good idea to test that already, thx :)

I'd also recommend to move CMake to the root tree. There are a few IDEs (KDevelop, QtCreator) that have some issues if the main CMakeLists.txt is in a subdirectory and it'll be just easier for everyone.

For the current state:

Android should be fine now
For rbpi, this lines have to be removed: https://github.com/xbmc/xbmc/blob/master/tools/buildsteps/rbpi/prepare-xbmc#L6

Few more things to do, I just want to mention:

Drop Kodi.xcodeproj
docs/Readme.xyz need to be adapted

hudokkow · 2016-09-08T22:05:41Z

Heads up: https://github.com/hudokkow/xbmc/tree/cmake_move_to_root

hudokkow · 2016-11-14T21:42:05Z

Can you rebase please?

notspiff · 2016-11-14T21:54:38Z

done.

hudokkow · 2016-11-14T22:07:59Z

thx!
jenkins build this with addons please

hudokkow · 2016-11-15T10:09:03Z

Only RBPi failed: http://jenkins.kodi.tv/job/LINUX-RBPI/8630/console

++ JSON_BUILDER=/home/jenkins/workspace/LINUX-RBPI/tools/depends/xbmc-depends/i686-linux-gnu-native/bin/JsonSchemaBuilder
++ ./bootstrap
/home/jenkins/workspace/LINUX-RBPI/tools/buildsteps/rbpi/prepare-xbmc: line 6: ./bootstrap: No such file or directory
Build step 'Execute shell' marked build as failure
Set build name.
New build name is 'xbmc-PR10429-1ec7b39'
Variable with name 'BUILD_DISPLAY_NAME' already exists, current value: 'xbmc-PR10429-1ec7b39', new value: 'xbmc-PR10429-1ec7b39'
Finished: FAILURE

http://jenkins.kodi.tv/view/Automation/job/BuildMultiWithAddons-PR/48/

akva2 · 2016-11-15T10:59:43Z

well rbp still uses the autotools build so that is to be expected.

fetzerch · 2016-11-16T07:23:39Z

Nope rbpi is also built with cmake, but:

For rbpi, this lines have to be removed: https://github.com/xbmc/xbmc/blob/master/tools/buildsteps/rbpi/prepare-xbmc#L6

akva2 · 2016-11-16T09:02:35Z

thanks, removed.

fetzerch · 2016-11-16T18:19:46Z

hudo was faster kicking off the build ;) Builds fine now also on rbpi: http://jenkins.kodi.tv/job/LINUX-RBPI/8650/

hudokkow · 2016-11-16T18:52:48Z

😜

Arne, unless we decide to generate a config.h file with CMake, you might want to pick and squash hudokkow@faa43f2

There's probably other defines in need of cleanup but it's hard to find them.

akva2 · 2016-11-17T14:50:13Z

pulled. there was another commit in the branch but i left it out.

hudokkow · 2016-11-17T15:10:29Z

Thanks. The other commit isn't related. It was just to make sure I didn't killed win builds after that ifdeferry cleanup.

stefansaraev · 2016-12-02T19:54:52Z

it's time..

fetzerch · 2016-12-02T20:21:26Z

I'll merge #10509 now if it still builds fine.
We should however get the confirmation from @Memphiz that cmake works for him as the legacy xcode build depends on autotools.

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738, 598460, 598460

hudokkow · 2016-12-14T23:25:05Z

jenkins build and merge

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738, 598460, 598460

MartijnKaijser · 2016-12-15T05:54:45Z

Failure on android build

hudokkow · 2016-12-15T10:38:34Z

All good: http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-All/1838/

Goodbye old friend.
Thx Arne!

notspiff · 2016-12-15T10:47:13Z

6 years. a shitload of pain. let me take the opportunity to say 'HAHA' to those that said it couldn't be done. to everybody else: thank you from the bottom of my heart for helping out.

hudokkow · 2016-12-15T10:48:42Z

Congrats!

MartijnKaijser · 2016-12-15T10:51:38Z

@notspiff thanks a lot :)

hauihau · 2016-12-15T11:00:01Z

Great job guys! :)

wsnipex · 2016-12-15T11:33:49Z

yeah, great job!

fetzerch · 2016-12-15T18:49:04Z

omg it happened! Thanks all :)

garbear · 2016-12-15T19:00:17Z

hm, this would useful in my retroplayer branch. feel like backporting? ;)

ksooo · 2016-12-15T19:16:54Z

Hi, afaik building (dependencies) on macOS relies on autotools. How do I build stuff on macOS now?

EDIT: I'm a build system dummy. So forgive me, if this is just a stupid question. :-)

stefansaraev · 2016-12-15T19:35:40Z

just like before. cd tools/depends; ./bootstrap; ./configure -- .....

Rechi · 2016-12-15T19:38:50Z

I think https://github.com/xbmc/xbmc/tree/dea9386/tools/depends/target/xbmc is useless now.

ksooo · 2016-12-15T21:45:07Z

macOS: works just fine. nice. thanks

Memphiz · 2016-12-16T12:37:50Z

@fetzerch care to update docs/README.osx and docs/README.ios with the newest build instructions?

fetzerch · 2016-12-16T17:19:33Z

@fetzerch care to update docs/README.osx and docs/README.ios with the newest build instructions?

Shit, https://github.com/xbmc/xbmc/blob/master/docs/README.osx#L125 now just reminded me that I have forgotten about a small but very important detail. osx/ios builds still need make xcode_depends which builds some libs like cpluff, libexif and the addon callback libs. Really sorry bout that :(

I'd see the following choices to go on:

xcode users switch to the cmake generated xcode project (and I help ironing out the issues you run into)
we get the removed functionality back (maybe @wsnipex could check how much that is for the makefiles), in parallel I can look into what would be needed to build only those libs with cmake.
we fully revert the change until you're happy with the generated xcode project and xcode users switched to cmake (I don't think that's a good solution considering the amount of work spent rebasing this change over and over again, especially now that we have pretty invasive changes going into master)

hudokkow · 2016-12-16T17:57:49Z

No revert, please. Last resource solution, imo.

Memphiz · 2016-12-17T10:55:42Z

First option it is. Then this needs to be described in the readme.

FernetMenta · 2016-12-17T16:29:29Z

what is the current state? as far as I understand it building for OSX is broken because things like libdvd are not built?

Memphiz · 2016-12-17T16:43:23Z

As far as understand it's not as long as you use cmake - the Xcode project is useless now though

FernetMenta · 2016-12-17T16:51:48Z

ah ok. why don't we drop the old xcode project?

fetzerch · 2016-12-17T17:38:33Z

I'll update the readme and explain how to build with cmake.
For the moment: https://github.com/xbmc/xbmc/blob/master/project/cmake/README.md

hauihau · 2016-12-18T20:10:56Z

cmake in contrast to autotools now also installs /usr/bin/TexturePacker. Correct me if I'm wrong, but texturepacker is only used while building. Wouldn't it make sense to skip it from installing?

hudokkow · 2016-12-18T22:15:36Z

^^ Something to discuss with @cjmayo for #11213?

hudokkow added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia labels Sep 8, 2016

notspiff force-pushed the remove_autotools branch from ce1a8c8 to 66cb8b8 Compare November 14, 2016 21:54

notspiff force-pushed the remove_autotools branch from 66cb8b8 to eb9e38b Compare November 16, 2016 09:01

notspiff force-pushed the remove_autotools branch from eb9e38b to 3e24af4 Compare November 17, 2016 14:49

BrandonSchaefer mentioned this pull request Dec 2, 2016

Use DRM as a fallback if not on X11 for VAAPI #10922

Merged

9 tasks

candrews added a commit to candrews/gentoo that referenced this pull request Dec 5, 2016

media-tv/kodi-9999: Use cmake instead of autotools

6517fc4

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738

candrews added a commit to candrews/gentoo that referenced this pull request Dec 5, 2016

media-tv/kodi-9999: Use cmake instead of autotools

2724768

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738

candrews mentioned this pull request Dec 5, 2016

media-tv/kodi-9999: Use cmake instead of autotools gentoo/gentoo#3027

Closed

candrews added a commit to candrews/gentoo that referenced this pull request Dec 11, 2016

media-tv/kodi-9999: Use cmake instead of autotools

10f47bb

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738, 598460, 598460

candrews added a commit to candrews/gentoo that referenced this pull request Dec 11, 2016

media-tv/kodi-9999: Use cmake instead of autotools

8a6b2c3

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738, 598460, 598460

candrews added a commit to candrews/gentoo that referenced this pull request Dec 15, 2016

media-tv/kodi-9999: Use cmake instead of autotools

c82ba59

Upstream is dropping support for autotools and requiring the use of cmake: xbmc/xbmc#10429 Gentoo-bug: 601738, 598460, 598460

hudokkow mentioned this pull request Dec 15, 2016

CMake: Fix TexturePacker installation directory #11144

Merged

hudokkow merged commit dea9386 into xbmc:master Dec 15, 2016

hudokkow added this to the L 18.0-alpha1 milestone Dec 15, 2016

hudokkow mentioned this pull request Dec 18, 2016

[Xcode] Remove deprecated project file #11217

Merged

notspiff deleted the remove_autotools branch October 29, 2017 21:35

Remove autotools #10429

Remove autotools #10429

Conversation

notspiff commented Sep 8, 2016

akva2 commented Sep 8, 2016

fritsch commented Sep 8, 2016

hudokkow commented Sep 8, 2016 • edited Loading

akva2 commented Sep 8, 2016

fetzerch commented Sep 8, 2016 • edited Loading

hudokkow commented Sep 8, 2016

hudokkow commented Nov 14, 2016

notspiff commented Nov 14, 2016

hudokkow commented Nov 14, 2016

hudokkow commented Nov 15, 2016

akva2 commented Nov 15, 2016

fetzerch commented Nov 16, 2016 • edited Loading

akva2 commented Nov 16, 2016

fetzerch commented Nov 16, 2016

hudokkow commented Nov 16, 2016

akva2 commented Nov 17, 2016

hudokkow commented Nov 17, 2016

stefansaraev commented Dec 2, 2016

fetzerch commented Dec 2, 2016

hudokkow commented Dec 14, 2016

MartijnKaijser commented Dec 15, 2016

hudokkow commented Dec 15, 2016

notspiff commented Dec 15, 2016 via email

hudokkow commented Dec 15, 2016

MartijnKaijser commented Dec 15, 2016

hauihau commented Dec 15, 2016

wsnipex commented Dec 15, 2016

fetzerch commented Dec 15, 2016

garbear commented Dec 15, 2016

ksooo commented Dec 15, 2016 • edited Loading

stefansaraev commented Dec 15, 2016 • edited Loading

Rechi commented Dec 15, 2016

ksooo commented Dec 15, 2016

Memphiz commented Dec 16, 2016

fetzerch commented Dec 16, 2016

hudokkow commented Dec 16, 2016

Memphiz commented Dec 17, 2016 • edited Loading

FernetMenta commented Dec 17, 2016

Memphiz commented Dec 17, 2016

FernetMenta commented Dec 17, 2016

fetzerch commented Dec 17, 2016

hauihau commented Dec 18, 2016

hudokkow commented Dec 18, 2016

hudokkow commented Sep 8, 2016 •

edited

Loading

fetzerch commented Sep 8, 2016 •

edited

Loading

fetzerch commented Nov 16, 2016 •

edited

Loading

ksooo commented Dec 15, 2016 •

edited

Loading

stefansaraev commented Dec 15, 2016 •

edited

Loading

Memphiz commented Dec 17, 2016 •

edited

Loading