VideoPlayer: advanced setting for max tempo #13325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rechi
reviewed
Jan 7, 2018
| bool CProcessInfo::IsTempoAllowed(float tempo) | ||
| { | ||
| if (tempo > 0.75 && tempo < 1.55) | ||
| if (tempo > MinTempoPlatform() && | ||
| (tempo < MaxTempoPlatform() || tempo < g_advancedSettings.m_maxTempo)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
13 tasks
|
Wiki done... https://kodi.wiki/view/Advancedsettings.xml#video
|
freakynl
added a commit
to freakynl/xbmc
that referenced
this pull request
Nov 2, 2020
Would like to be able to lower playback speed beyond 0.8. Currently hard-coded. Found: xbmc#13325 which made maxTempo configurable. Don't get his comment on that it's supposed to only be capable of overriding the max (in response to Rechi xbmc#13325 (comment))
freakynl
pushed a commit
to freakynl/xbmc
that referenced
this pull request
Nov 2, 2020
Not sure why only maxTempo was added in that commit. FernetMenta did react to Rechi that this was intended, I have no idea why unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users demanding max tempo > 1.5 but this won't work in general on all platforms. So far platform devs did not override maxTempo.
The advanced setting gives users the chance to experiment.