Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vfs][addons][audiodecoder] continue addon search if open of extension failed #18422

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

AlwinEsch
Copy link
Member

@AlwinEsch AlwinEsch commented Sep 14, 2020

Description

This thought for the case that a addon tried with a extension where can also be on other types.

Before has it exited the function and no further search to find process part.

The error and fix specially visible by *.iso's and use of audiodecoder.sacd with vfs.libarchive (where iso support added).

Before has it called the audiodecoder where fails on a normal file ISO and returned the scan function as unsupported.
With this change here is the search continued and try then also with other addons and with Kodi's own VFS support.

User related:

  • If the audio decoder start fails, try to find its supported file extensions on other addons or Kodi.
    • Previously the search for audio decoders was interrupted if it supported the ending but failed to open.

Motivation and Context

Related to request here on vfs.libarchive: xbmc/vfs.libarchive#40

Before with vfs.sacd was it not so easy (but maybe also possible 🤔), but with audiodecoder.sacd them are a bit independent and then allow with here to play a SACD iso and also to open a normal files ISO.

ping @zach-morris think we can become your request in 😄

How Has This Been Tested?

With audiodecoder.sacd and vfs.libarchive and open of several ISO's.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

…n failed

This thought for the case that a addon tried with a extension where can also be on other types.

Before has it returned the function and no further search to find process part.

The error and fix specially visible by *.iso's and use of audiodecoder.sacd with vfs.libarchive (where iso support added).

Before has it called the audiodecoder where fails on a normal file ISO and returned the scan function as unsupported.
With this change here is the search continued and try then also with other addons and with Kodi's own VFS support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Binary add-ons Component: FileSystem Filesystem Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant