Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon seems to compete with vfs.libarchive #29

Open
Tratoschek opened this issue Jul 23, 2018 · 13 comments
Open

Addon seems to compete with vfs.libarchive #29

Tratoschek opened this issue Jul 23, 2018 · 13 comments
Labels
Bug confirmed To define by dev that it was reproducable Kodi related To define by dev that fault comes from Kodi itself and mostly not possible to fix on addon Typ: Bug To define by user as the related part not work, but Kodi can still be further used

Comments

@Tratoschek
Copy link

Activating this addon and vfs.libarchive results in ignoring any rar-archive (maybe because both addons register the rar extension).

@notspiff
Copy link
Collaborator

yes, that is to be expected. use one or the other.

@Tratoschek
Copy link
Author

Ok. Can you mention it in the README? My expectation was that Kodi either warn about multiple registrations of the same handler or somehow prefer one of them. Of course this is a Kodi issue but some users may be less confused, if you mention it in the README.

@notspiff
Copy link
Collaborator

notspiff commented Jul 24, 2018

actually, i tested it again. it seems the problem has gone away (it was symbol clashes). it works for me with both enabled. i need a debug log to proceed further.

though i would like to point out that there is no reason to keep using vfs.rar.

@AlwinEsch
Copy link
Member

This need changes on Kodi itself, I look in future about a fix it and allow a selection in settings about wanted addon to use

@zach-morris
Copy link

Would it be possible to add a unique protocol for vfs.rar? Especially with Kodi v19 and solid rar archive support if you were to add:

protocols="rar|rar_solid"

or

protocols="rar|rars"

or similar. Then on the python side the addon creator could define it as a unique option.

@AlwinEsch
Copy link
Member

I think to add a system to make the extensions and mimetypes selectable and set the wanted addon (or to Kodi if supported) in Settings and also inform the user if he install a addon where already supported somewhere else.

There also some other addons where it supported on different.

Can also look then to allow python side to force to one.

@AlwinEsch
Copy link
Member

It think to remove the RAR support from vfs.libarchive when this here is stable enough.

For future, maybe Kodi N* I look to allow selection like wrote in comment before.

@zach-morris
Copy link

zach-morris commented Apr 8, 2020

I was able to resolve this issue via python as a workaround, using this module for testing.

#Sleep call is currently requried to avoid crashing Kodi
xbmc.sleep(1000)
xbmc.executeJSONRPC('{ "jsonrpc": "2.0", "method": "Addons.SetAddonEnabled","params":{"addonid": "vfs.libarchive", "enabled": false} }') #Temporarily disable vfs.libarchive
xbmc.sleep(1000)
my_archive = archive_tool.archive_tool(archive_file = 'myfile.rar',directory_out = '/my/output_directory/', use_vfs_rar=True) #Current archive object using vfs.rar instead of vfs.libarchive

xbmc.executeJSONRPC('{ "jsonrpc": "2.0", "method": "Addons.SetAddonEnabled","params":{"addonid": "vfs.libarchive", "enabled": true} }') #re-enable vfs.libarchive
xbmc.sleep(1000)

@highlandr
Copy link

I would just remove the rar from libarchive :)
If you need tests and logs to get RAR more stable just ask!
The only thing I see different from the old 17.6 kodi is that browsing now is a bit more slower (when browsing directories with big library of rar files).
Cheers!

@AlwinEsch AlwinEsch added Bug confirmed To define by dev that it was reproducable Kodi related To define by dev that fault comes from Kodi itself and mostly not possible to fix on addon Typ: Bug To define by user as the related part not work, but Kodi can still be further used labels Apr 18, 2020
@AlwinEsch
Copy link
Member

I remove next days the rar support from vfs.libarchive addon, think here now more stable as the other.

About the speed, before was a more own hack way used to use the RAR lib (also was his lib code there much smaller), with change to newest version of them (v5) was it no more so easy to use hack way and was changed to take original API about.

Maybe I can become it a bit faster, but for the old speed I think it doesn't work anymore

@AlwinEsch
Copy link
Member

On Kodi Matrix by vfs.libarchive is now the rar support removed and this here then always usable.

@zach-morris
Copy link

Does this recent merge change the methodology here at all?

@AlwinEsch
Copy link
Member

AlwinEsch commented Sep 17, 2020

There only about audiodecoder where checked before vfs addons (and if audiodecoders failed to use VFS).
About VFS only currently not possible.

The vfs.sacd was more of a special case because its ISO something else. Regarding RAR this would be more difficult, since vfs.libarchive and vfs.rar support exactly the same format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug confirmed To define by dev that it was reproducable Kodi related To define by dev that fault comes from Kodi itself and mostly not possible to fix on addon Typ: Bug To define by user as the related part not work, but Kodi can still be further used
Projects
None yet
Development

No branches or pull requests

5 participants