-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon seems to compete with vfs.libarchive #29
Comments
yes, that is to be expected. use one or the other. |
Ok. Can you mention it in the README? My expectation was that Kodi either warn about multiple registrations of the same handler or somehow prefer one of them. Of course this is a Kodi issue but some users may be less confused, if you mention it in the README. |
actually, i tested it again. it seems the problem has gone away (it was symbol clashes). it works for me with both enabled. i need a debug log to proceed further. though i would like to point out that there is no reason to keep using vfs.rar. |
This need changes on Kodi itself, I look in future about a fix it and allow a selection in settings about wanted addon to use |
Would it be possible to add a unique protocol for vfs.rar? Especially with Kodi v19 and solid rar archive support if you were to add:
or
or similar. Then on the python side the addon creator could define it as a unique option. |
I think to add a system to make the extensions and mimetypes selectable and set the wanted addon (or to Kodi if supported) in Settings and also inform the user if he install a addon where already supported somewhere else. There also some other addons where it supported on different. Can also look then to allow python side to force to one. |
It think to remove the RAR support from vfs.libarchive when this here is stable enough. For future, maybe Kodi N* I look to allow selection like wrote in comment before. |
I was able to resolve this issue via python as a workaround, using this module for testing.
|
I would just remove the rar from libarchive :) |
I remove next days the rar support from vfs.libarchive addon, think here now more stable as the other. About the speed, before was a more own hack way used to use the RAR lib (also was his lib code there much smaller), with change to newest version of them (v5) was it no more so easy to use hack way and was changed to take original API about. Maybe I can become it a bit faster, but for the old speed I think it doesn't work anymore |
On Kodi Matrix by vfs.libarchive is now the rar support removed and this here then always usable. |
Does this recent merge change the methodology here at all? |
There only about audiodecoder where checked before vfs addons (and if audiodecoders failed to use VFS). The vfs.sacd was more of a special case because its ISO something else. Regarding RAR this would be more difficult, since vfs.libarchive and vfs.rar support exactly the same format. |
Activating this addon and vfs.libarchive results in ignoring any rar-archive (maybe because both addons register the rar extension).
The text was updated successfully, but these errors were encountered: