Fix video in slideshow not show and hang in black problem. #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the point of this is. Videos can also have a PictureInfoTag as videos from digital cameras can also have EXIF data. |
|
I think current PictureInfoTag implement only support jpeg file. so don't |
|
It doesn't. I've seen it populate videos with EXIF data. Frankly, I don't know where it's used, but it's a more complete implementation. |
|
Should we use mimetype to expose EXIF or is the original PR better? Or don't we need this EXIF data in the GUI at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple version of #2164
By call GetMimeType() for items without either picture or video info tag. then we can detect video item. current old code will trade such items as picture and hang there.
There will be additional commit for minor fix slideshow video related problem will be added after this, but less than what in #2164 thanks @DigitalDJ for the initial PR for this.