[omxplayer] Support stereo view modes with scaling #4703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pi only supported a single view rectangle, which is sufficient for all mono view modes, but only supports a subset of stereo modes. To work around this, the scaling rectangles were ignored in 3D modes and 3D video was treated as unscaled. While this worked or square pixel, 16:9 content on a 16:9 display, it went wrong is various other conditions. @sraue reported that mono view of SBS/TAB content wasn't scaled correctly, and other forum reports aspect ratio errors in widescreen 3D videos. As it wasn't trivial to work around these bug reports, I've added a new stereo flags to the firmware that allows a second display region to be created for the second eye, allowing scaling to work. I've been through the video stereo modes (none, sbs, tab) and the display stereo modes (mono, sbs, tab) and all the zoom modes, and compared the scaling to xbmc on windows and all seem to match Requires udpated firmware.
|
This patch is in OpenELEC 4.0 release. |
|
jenkins build this please |
MartijnKaijser
added a commit
that referenced
this pull request
May 21, 2014
[omxplayer] Support stereo view modes with scaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pi only supported a single view rectangle, which is sufficient for all mono view modes,
but only supports a subset of stereo modes.
To work around this, the scaling rectangles were ignored in 3D modes and 3D video was treated as unscaled.
While this worked or square pixel, 16:9 content on a 16:9 display, it went wrong is various other conditions.
@sraue reported that mono view of SBS/TAB content wasn't scaled correctly, and other forum reports
aspect ratio errors in widescreen 3D videos.
As it wasn't trivial to work around these bug reports, I've added a new stereo flags to the firmware
that allows a second display region to be created for the second eye, allowing scaling to work.
I've been through the video stereo modes (none, sbs, tab) and the display stereo modes (mono, sbs, tab)
and all the zoom modes, and compared the scaling to xbmc on windows and all seem to match
Requires udpated firmware.