show correct dialog header text for master lock code. fixes #15543 #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. comment is obviously wrong, just remove it:) |
MartijnKaijser
force-pushed
the
15543
branch
from
dca6d50
to
7147e31
Compare
MartijnKaijser
added a commit
that referenced
this pull request
Nov 16, 2014
show correct dialog header text for master lock code. fixes #15543
|
after having some beers the comment is actually correct. if you change mode the password is reset and you need to enter a new one. as such i adjusted the comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old header: "Ask for master lock code on startup"
new header: "Master lock"
note:
is that comment that you see in the diff correct? because the dialog actually shows: