Merged support for audio/L16 mimetype from andrewfg PR 251 #777

jmarshallnz · 2012-03-17T09:54:21Z

c0diq thinks this should be Eden material.

As far as I can tell, the changes are both sane (fixes a bug) and have minimal impact.

Tested build on osx. Needs build test on win32/ios/atv2, plus general signoff.

wsoltys · 2012-03-17T11:52:45Z

compiles fine on win32 but two things I noticed:

l16 and pcm extensions aren't added
I didn't found good/right test files for it but with the wavs I've tested I just get noise (PCM S16 LE araw, PCM MU-LAW mlaw) even though the content type equals audio/l16.

At least the PCM S16 LE araw plays fine without this patch.

Memphiz · 2012-03-17T14:36:24Z

Builds for ios/atv2 and linux. But i'm too struggling with testfiles and test procedure here.

c0diq · 2012-03-17T16:36:22Z

http://tools.ietf.org/html/rfc2586

audio/L16 L16 denotes uncompressed audio data, using 16-bit signed representation in twos-complement notation and network byte order.

c0diq · 2012-03-17T16:39:59Z

is it possible that we should be using Endian_SwapLE16 instead of Endian_Swap?

c0diq · 2012-03-17T20:20:32Z

I think we should be using ntohs instead of Endian_Swap to make sure it works on all system. Input is expected to be BigEndian (network byte order).

c0diq · 2012-03-17T20:21:13Z

To test find a raw pcm in BigEndian format.

elupus · 2012-03-18T11:43:27Z

Fine by me.

c0diq · 2012-03-18T15:26:07Z

I think it should use ntohs instead of EndianzSwap otherwise it might not work on Linux system right?

-s

On Mar 18, 2012, at 4:43 AM, Joakim Plate reply@reply.github.com wrote:

Fine by me.

Reply to this email directly or view it on GitHub:
#777 (comment)

jmarshallnz · 2012-03-19T00:27:15Z

EndianSwap16() definitely isn't right - it'll swap it to LE regardless of host. We want the equivalent of EndianSwapBE16 instead (currently non-existent), which won't swap on a BE host.

I personally don't mind if ntohs is used if it's universally available, but given it's not currently used in the XBMC codebase, perhaps using EndianSwapBE16() is better - will append a patch.

c0diq · 2012-03-19T02:12:41Z

ntohs is used in many places in xbmc.
I don't have a Linux env to try. Both osx and win are little Endian, so I don't know why you think EndianSwapBE16 be better?

-s

On Mar 18, 2012, at 5:27 PM, jmarshallnz reply@reply.github.com wrote:

EndianSwap16() definitely isn't right - it'll swap it to LE regardless of host. We want the equivalent of EndianSwapBE16 instead (currently non-existent), which won't swap on a BE host.

I personally don't mind if ntohs is used if it's universally available, but given it's not currently used in the XBMC codebase, perhaps using EndianSwapBE16() is better - will append a patch.

Reply to this email directly or view it on GitHub:
#777 (comment)

jmarshallnz · 2012-03-19T02:29:35Z

I probably typo'd the random string of characters in my grep :p

I don't have any preference whatsoever - I merely took the route of least resistance that didn't involve having to play with headers (I think <netinet/in.h> is OK on win32 but didn't want to be bothered looking into it). You're welcome to change it to use ntohs if you prefer - send details and I'll slot it in.

It'd be great if you (or someone) could supply a sample file so that others can test it out - they appear to be thin on the ground.

c0diq · 2012-03-19T04:25:50Z

You are right. I created a EndianSwapBE16 function. I also fixed an issue where wav file were playing noise now. That's because wav somehow end up with audio/l16 mimetype which triggered the PCMCodec incorrectly. Now why wav have this mimetype I don't get it. I have the fixes, should I close this request and pull a new one?

c0diq · 2012-03-19T04:35:31Z

ok I see you did the same thing ;-)

c0diq · 2012-03-19T04:57:28Z

Added a sample .l16 file for testing http://cl.ly/F8Da

jmarshallnz · 2012-03-19T04:57:58Z

Just link me the fixes and I'll pull 'em in to this branch.

jmarshallnz · 2012-03-19T05:11:20Z

wave files seem to work fine for me. Have checked the .l16 file you linked to - works fine.

c0diq · 2012-03-19T06:19:03Z

Excellent. Then we're good.

-s

Sent from my iPad

On Mar 18, 2012, at 10:11 PM, jmarshallnz reply@reply.github.com wrote:

wave files seem to work fine for me. Have checked the .l16 file you linked to - works fine.

Reply to this email directly or view it on GitHub:
#777 (comment)

bossanova808 · 2012-03-19T10:39:28Z

Does the PR wholly subsume PR251? I believe this will enable direct play of lossless streams from logitech music server (squeezebox ecosystem) if so, so I am curious as my add on is in this area...

c0diq · 2012-03-19T17:23:16Z

yes it does. What's lossless streams from logitech?

Memphiz · 2012-03-19T19:22:13Z

Confirmed, that that test file didn't play before this PR (xbmc just crashed) and played after applying the patch. Tested on OSX and iOS.

So basically funk is flowing through my veins now :)

bossanova808 · 2012-03-19T22:55:04Z

Basically Logitech Media Server is a music (I think it does pictures and
video now too) app from Logitech to support the Squeezebox line of network
audio players. And apparently LMS supplies streams in this format when
streaming lossless files like flac etc.

A long time ago Squeezeboxes were the most awesome network music players,
like a Sonos but a lot cheaper, more flexible, and with open source
software. Their star has faded (basically since logitech bought out the
excellent small company behind the players, slimdevices) - but a lot of
people have these around their house so the idea is to have XBMC integrate
into a bunch of these existing players for a whole house audio solution I
guess.

My add on currently includes an external headless software player, but
ideally the stream could be handed direct to XBMC's player for better
integration into XBMC (although the sync will almost certainly be less good
so the idea is to have both options).

It's all purely an exercise for me - I just use XBMC's internal music
system myself, for the most part, but others seem keen and nobody else was
doing it so I thought I'd extend my python skills a bit.

On Tue, Mar 20, 2012 at 6:22 AM, Memphiz <
reply@reply.github.com

wrote:

Confirmed, that that test file didn't play before this PR (xbmc just
crashed) and played after applying the patch. Tested on OSX and iOS.

So basically funk is flowing through my veins now :)

Reply to this email directly or view it on GitHub:
#777 (comment)

c0diq · 2012-03-19T23:19:14Z

Flax and L16 are different.

-s

On Mar 19, 2012, at 3:55 PM, bossanova808 reply@reply.github.com wrote:

Basically Logitech Media Server is a music (I think it does pictures and
video now too) app from Logitech to support the Squeezebox line of network
audio players. And apparently LMS supplies streams in this format when
streaming lossless files like flac etc.

A long time ago Squeezeboxes were the most awesome network music players,
like a Sonos but a lot cheaper, more flexible, and with open source
software. Their star has faded (basically since logitech bought out the
excellent small company behind the players, slimdevices) - but a lot of
people have these around their house so the idea is to have XBMC integrate
into a bunch of these existing players for a whole house audio solution I
guess.

My add on currently includes an external headless software player, but
ideally the stream could be handed direct to XBMC's player for better
integration into XBMC (although the sync will almost certainly be less good
so the idea is to have both options).

It's all purely an exercise for me - I just use XBMC's internal music
system myself, for the most part, but others seem keen and nobody else was
doing it so I thought I'd extend my python skills a bit.

On Tue, Mar 20, 2012 at 6:22 AM, Memphiz <
reply@reply.github.com

wrote:

Confirmed, that that test file didn't play before this PR (xbmc just
crashed) and played after applying the patch. Tested on OSX and iOS.

So basically funk is flowing through my veins now :)

Reply to this email directly or view it on GitHub:
#777 (comment)

Reply to this email directly or view it on GitHub:
#777 (comment)

bossanova808 · 2012-03-20T00:09:35Z

Yep I know that, I believe LMS transcodes to PCM16 - the PR251 was all
about this....that guy develops a DLNA/UPNP extension to LMS

Merged support for audio/L16 mimetype from andrewfg PR 251

Fixes xbmc#777

…development * change_postprocess_ignore_hidden_pass_nzb_delete: closes xbmcgh-803 Change PostProcessing checks and rules + Change replace rules and inner workings closes xbmcgh-393 + Include PR-620-jayme-github Process files by size but reversed (biggest first) closes xbmcgh-620 + Add postProcessor checks: status, quality/filesize, already processed closes xbmcgh-629 + Change search for airdate in database instead of thetvdb + Add tv download dir as default manual post-process directory closes xbmcgh-722 + Add is_proper to nameparser + Change use quality from snatch history instead of status quality + PEP8 Add ignore hidden, pass nzb, delete empty to processTV Add ignore hidden subfolders (subfolder starts with .) Removing ignored_filestrings from postProcessor because subfolders with . are not being processed. Add pass (inherit) nzbName to subfolder When no videofiles are in the mainfolder and there is only one subfolder, pass nzbName to subfolder Add delete empty folder closes xbmcgh-777 For now only delete empty folders on scripts and automatic. Safety net, with manual it's easier to browse and select root folder + Change some logging and error messages closes xbmcgh-702 closes xbmcgh-664 closes

Jonathan Marshall and others added 2 commits March 19, 2012 13:40

add Endian_SwapBE16/32/64

ddd5ae0

Merged support for audio/L16 mimetype from andrewfg PR 251

163fbda

jmarshallnz added a commit that referenced this pull request Mar 20, 2012

Merge pull request #777 from jmarshallnz/audio_l16_mimetype

7fad808

Merged support for audio/L16 mimetype from andrewfg PR 251

jmarshallnz merged commit 7fad808 into xbmc:master Mar 20, 2012

Montellese mentioned this pull request Mar 20, 2012

add websocket support for JSON-RPC #511

Merged

tru pushed a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 12, 2013

Fix channel names on Window

312157d

Fixes xbmc#777

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merged support for audio/L16 mimetype from andrewfg PR 251 #777

Merged support for audio/L16 mimetype from andrewfg PR 251 #777

jmarshallnz commented Mar 17, 2012

wsoltys commented Mar 17, 2012

Memphiz commented Mar 17, 2012

c0diq commented Mar 17, 2012

c0diq commented Mar 17, 2012

c0diq commented Mar 17, 2012

c0diq commented Mar 17, 2012

elupus commented Mar 18, 2012

c0diq commented Mar 18, 2012

jmarshallnz commented Mar 19, 2012

c0diq commented Mar 19, 2012

jmarshallnz commented Mar 19, 2012

c0diq commented Mar 19, 2012

c0diq commented Mar 19, 2012

c0diq commented Mar 19, 2012

jmarshallnz commented Mar 19, 2012

jmarshallnz commented Mar 19, 2012

c0diq commented Mar 19, 2012

bossanova808 commented Mar 19, 2012

c0diq commented Mar 19, 2012

Memphiz commented Mar 19, 2012

bossanova808 commented Mar 19, 2012

c0diq commented Mar 19, 2012

bossanova808 commented Mar 20, 2012

Merged support for audio/L16 mimetype from andrewfg PR 251 #777

Merged support for audio/L16 mimetype from andrewfg PR 251 #777

Conversation

jmarshallnz commented Mar 17, 2012

wsoltys commented Mar 17, 2012

Memphiz commented Mar 17, 2012

c0diq commented Mar 17, 2012

c0diq commented Mar 17, 2012

c0diq commented Mar 17, 2012

c0diq commented Mar 17, 2012

elupus commented Mar 18, 2012

c0diq commented Mar 18, 2012

jmarshallnz commented Mar 19, 2012

c0diq commented Mar 19, 2012

jmarshallnz commented Mar 19, 2012

c0diq commented Mar 19, 2012

c0diq commented Mar 19, 2012

c0diq commented Mar 19, 2012

jmarshallnz commented Mar 19, 2012

jmarshallnz commented Mar 19, 2012

c0diq commented Mar 19, 2012

bossanova808 commented Mar 19, 2012

c0diq commented Mar 19, 2012

Memphiz commented Mar 19, 2012

bossanova808 commented Mar 19, 2012

c0diq commented Mar 19, 2012

bossanova808 commented Mar 20, 2012