Skip to content

Merged support for audio/L16 mimetype from andrewfg PR 251 #777

Merged
merged 2 commits into from Mar 20, 2012

7 participants

@jmarshallnz
Team Kodi member

c0diq thinks this should be Eden material.

As far as I can tell, the changes are both sane (fixes a bug) and have minimal impact.

Tested build on osx. Needs build test on win32/ios/atv2, plus general signoff.

@wsoltys
Team Kodi member
wsoltys commented Mar 17, 2012

compiles fine on win32 but two things I noticed:
1) l16 and pcm extensions aren't added
2) I didn't found good/right test files for it but with the wavs I've tested I just get noise (PCM S16 LE araw, PCM MU-LAW mlaw) even though the content type equals audio/l16.

At least the PCM S16 LE araw plays fine without this patch.

@Memphiz
Team Kodi member
Memphiz commented Mar 17, 2012

Builds for ios/atv2 and linux. But i'm too struggling with testfiles and test procedure here.

@c0diq
c0diq commented Mar 17, 2012

http://tools.ietf.org/html/rfc2586

audio/L16 L16 denotes uncompressed audio data, using 16-bit signed representation in twos-complement notation and network byte order.

@c0diq
c0diq commented Mar 17, 2012

is it possible that we should be using Endian_SwapLE16 instead of Endian_Swap?

@c0diq
c0diq commented Mar 17, 2012

I think we should be using ntohs instead of Endian_Swap to make sure it works on all system. Input is expected to be BigEndian (network byte order).

@c0diq
c0diq commented Mar 17, 2012

To test find a raw pcm in BigEndian format.

@elupus
Team Kodi member
@c0diq
c0diq commented Mar 18, 2012
@jmarshallnz
Team Kodi member

EndianSwap16() definitely isn't right - it'll swap it to LE regardless of host. We want the equivalent of EndianSwapBE16 instead (currently non-existent), which won't swap on a BE host.

I personally don't mind if ntohs is used if it's universally available, but given it's not currently used in the XBMC codebase, perhaps using EndianSwapBE16() is better - will append a patch.

@c0diq
c0diq commented Mar 19, 2012
@jmarshallnz
Team Kodi member

I probably typo'd the random string of characters in my grep :p

I don't have any preference whatsoever - I merely took the route of least resistance that didn't involve having to play with headers (I think is OK on win32 but didn't want to be bothered looking into it). You're welcome to change it to use ntohs if you prefer - send details and I'll slot it in.

It'd be great if you (or someone) could supply a sample file so that others can test it out - they appear to be thin on the ground.

@c0diq
c0diq commented Mar 19, 2012

You are right. I created a EndianSwapBE16 function. I also fixed an issue where wav file were playing noise now. That's because wav somehow end up with audio/l16 mimetype which triggered the PCMCodec incorrectly. Now why wav have this mimetype I don't get it. I have the fixes, should I close this request and pull a new one?

@c0diq
c0diq commented Mar 19, 2012

ok I see you did the same thing ;-)

@c0diq
c0diq commented Mar 19, 2012

Added a sample .l16 file for testing http://cl.ly/F8Da

@jmarshallnz
Team Kodi member

Just link me the fixes and I'll pull 'em in to this branch.

@jmarshallnz
Team Kodi member

wave files seem to work fine for me. Have checked the .l16 file you linked to - works fine.

@c0diq
c0diq commented Mar 19, 2012
@bossanova808

Does the PR wholly subsume PR251? I believe this will enable direct play of lossless streams from logitech music server (squeezebox ecosystem) if so, so I am curious as my add on is in this area...

@c0diq
c0diq commented Mar 19, 2012

yes it does. What's lossless streams from logitech?

@Memphiz
Team Kodi member
Memphiz commented Mar 19, 2012

Confirmed, that that test file didn't play before this PR (xbmc just crashed) and played after applying the patch. Tested on OSX and iOS.

So basically funk is flowing through my veins now :)

@bossanova808
@c0diq
c0diq commented Mar 19, 2012
@bossanova808
@jmarshallnz jmarshallnz merged commit 7fad808 into xbmc:master Mar 20, 2012
@manio

It took me some time to bisect it :)
I can't listen my music with this else block (tested on mp3 and flac files). Something is definitely wrong here (I am using x86_64 if it matters). Please tell me if you need further tests or additional info...

Team Kodi member

Grrr, this was changed from a Find in the original PR and I didn't pick it up - thanks for the fix.

@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 12, 2013
@tru tru Fix channel names on Window
Fixes #777
312157d
@HolgerW1 HolgerW1 pushed a commit to HolgerW1/xbmc that referenced this pull request Sep 26, 2014
@itofzo itofzo Merge branch 'change_postprocess_ignore_hidden_pass_nzb_delete' into …
…development

* change_postprocess_ignore_hidden_pass_nzb_delete: closes gh-803

Change PostProcessing checks and rules

+ Change replace rules and inner workings   closes gh-393
+ Include PR-620-jayme-github Process files by size but reversed (biggest first)  closes gh-620
+ Add postProcessor checks: status, quality/filesize, already processed  closes gh-629
+ Change search for airdate in database instead of thetvdb
+ Add tv download dir as default manual post-process directory  closes gh-722
+ Add is_proper to nameparser
+ Change use quality from snatch history instead of status quality
+ PEP8

Add ignore hidden, pass nzb, delete empty to processTV

Add ignore hidden subfolders (subfolder starts with .)
Removing ignored_filestrings from postProcessor
because subfolders with . are not being processed.

Add pass (inherit) nzbName to subfolder
When no videofiles are in the mainfolder and there is only one subfolder,
pass nzbName to subfolder

Add delete empty folder  closes gh-777
For now only delete empty folders on scripts and automatic.
Safety net, with manual it's easier to browse and select root folder

+ Change some logging and error messages  closes gh-702 closes gh-664 closes
9f309a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.