Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of an unmaintained dependency #517

Open
lapwil opened this issue Oct 10, 2023 · 5 comments
Open

Change of an unmaintained dependency #517

lapwil opened this issue Oct 10, 2023 · 5 comments

Comments

@lapwil
Copy link

lapwil commented Oct 10, 2023

Issue Description

The dependency to modal-react-native-web is no longer maintained as react-native-web as been change

Changes needed

If you could change your dependencies to accept the react-native-web that would be great as modal-react-native-web peer dependencies are unsafe for latest react and react-native configurations

If you want I can make the PR

@lapwil
Copy link
Author

lapwil commented Oct 10, 2023

My bad I just cloned your repo and saw that you made the change already, my issue came from another package I'm using that uses a previous version of your code.

Sorry

@lapwil lapwil closed this as completed Oct 10, 2023
@lapwil
Copy link
Author

lapwil commented Oct 10, 2023

Oh in fact, its your npm repo that is outdated and does not have this version of the code, can you update it ?

@lapwil lapwil reopened this Oct 10, 2023
@mcrstudio
Copy link

is the npm module going to be updated

@Svarto
Copy link

Svarto commented Jan 3, 2024

would be fantastic with an update...it is failing builds now due to peer dependency to React 16

@yushanwebdev
Copy link

@lapwil @mcrstudio @Svarto, you can start using this one if you like
https://github.com/yushanwebdev/react-native-country-picker-modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants