-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential bug in HelperFUnctions::IsSameFile() #13
Comments
Fixed. Thank you. |
No Problems. Looks like there maybe a few more from me as the unit tests are not right due to the use bool? data types From To |
Yes. fitdev added some changes recently and it fails on UnitTests due to change bool to bool? |
fixed according to your suggestion. Thank you again |
On line 641 of internal static bool IsSameFile(Stream streamOne, Stream streamTwo)
Is there any reason to check if the length of the same stream does not match? Should not one of those be streamTwo?
The text was updated successfully, but these errors were encountered: