Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Make and Model displayed in Center #147

Closed
OiWitcher opened this issue Mar 12, 2019 · 13 comments
Closed

Server Make and Model displayed in Center #147

OiWitcher opened this issue Mar 12, 2019 · 13 comments
Assignees
@borzel
Labels
enhancement New feature or request
Milestone
8.0.1

Comments

@OiWitcher
Copy link

Describe the bug
Add the hosts server make and model to the General tab? XOA and VMware both display this and it would be nice to have.

To Reproduce
Feature/enhancement request

Expected behavior
View make and model of the host under the General tab..

Screenshots / Logfiles
Similar to this from Vcenter:

image

Hard-/Software involved:

  • Client XCP-ng Center Version: All versions.

Additional context
Add any other context about the problem here.
@borzel borzel added the enhancement New feature or request label Apr 12, 2019
@borzel borzel added this to the 8.0.1 milestone May 11, 2019
@borzel borzel self-assigned this May 11, 2019
@borzel
Copy link
Member

borzel commented May 11, 2019

start to look into this

@borzel
Copy link
Member

borzel commented May 11, 2019 •
edited

@OiWitcher I think that is something you would like to see in the next release ;-)

grafik

borzel added a commit that referenced this issue May 11, 2019
@borzel
show bios strings as a new panel in the hosts general tab
c60ab4d 
#147
@borzel borzel mentioned this issue May 11, 2019
Merged
@borzel
Copy link
Member

borzel commented May 21, 2019

merged to development and release-xcp-ng-8.0

@borzel borzel closed this as completed May 21, 2019
@olivierlambert
Copy link
Member

@borzel please don't forget to try to get your work upstream. This will reduce your burden to re-merge all the diff for each XenCenter release

@borzel
Copy link
Member

borzel commented May 21, 2019

In my option it's not worth the work I put in. We all know they don't integrate the fancy stuff.

borzel added a commit that referenced this issue May 21, 2019
@borzel
show bios strings as a new panel in the hosts general tab
a2fc50e 
#147
@olivierlambert
Copy link
Member

Why? Are you sure? I have the feeling they might accept your PRs.

@borzel
Copy link
Member

borzel commented May 21, 2019

@olivierlambert I have to implement it into a plain xenadmin, test against a XenServer (because connect to XCP-ng will fail because CITRIX don't want xenadmin to connect to foreign XAPI servers), PR it.
If it's then in the upstream master, I have to revert my original modification.

If I don't PR it, I have less work.

@borzel
Copy link
Member

borzel commented May 21, 2019 •
edited

This will reduce your burden to re-merge all the diff for each XenCenter release

that's not the case any more, I created an up2date development branch in which I integrade the current upstream master from time to time.

@olivierlambert
Copy link
Member

IMHO, going upstream is the right strategy. Because you'll have to maintain more and more your branch, and sometimes it could lead to an impasse.

Also, pushing upstream is playing the Open Source game. At least try to make a PR, we'll see if they are willing to accept.

@borzel
Copy link
Member

borzel commented May 21, 2019 •
edited

I whish me a better upstream game master :-/ .... will try to put a PR together...

@borzel borzel reopened this May 21, 2019
borzel added a commit that referenced this issue May 21, 2019
@borzel
show bios strings as a new panel in the hosts general tab
57cf865 
#147
borzel added a commit that referenced this issue May 21, 2019
@borzel
show bios strings as a new panel in the hosts general tab
30d8b1f 
#147

# Conflicts:
#	XenAdmin/TabPages/GeneralTabPage.Designer.cs
#	XenAdmin/TabPages/GeneralTabPage.resx
@borzel borzel mentioned this issue May 21, 2019
Closed
@borzel
Copy link
Member

borzel commented May 21, 2019

Upstream PR created: xenserver#2440

@borzel borzel closed this as completed May 21, 2019
@stormi
Copy link
Member

stormi commented May 22, 2019

Great. I'll watch their reply.

@borzel
Copy link
Member

borzel commented Jul 10, 2019

It's now released: https://github.com/xcp-ng/xenadmin/releases/tag/v8.0.1.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borzel borzel

Labels
enhancement New feature or request
Projects
None yet
Milestone
8.0.1
Development

No branches or pull requests
4 participants
@stormi @olivierlambert @borzel @OiWitcher