Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove current execution position when performing stop or continue dbgp operation. #367

Merged
merged 2 commits into from
Feb 2, 2021
Merged

fix: remove current execution position when performing stop or continue dbgp operation. #367

merged 2 commits into from
Feb 2, 2021

Commits on Jan 2, 2021

  1. Fixes stopped indicator when performing stop or continue. 

    When the IDE requests a continue operation (step in, out, over, continue) it expects a Response and will remove the current execution position. With XDebug/DBGp the TCP connection will not send a response until another stop condition is encountered this may take an arbitrary amount of time.
This change fixes this by doing some basic validation (is the threadId valid) and then sends a response before executing the continuation command.

Closes xdebug#358
    @zobo
    zobo committed Jan 2, 2021
    Configuration menu
    Copy the full SHA
    37124d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Refactored step operations to cover all error scenarios. 

    Handle them, where possible, with sendErrorResponse and OutputEvent in other cases.
    @zobo
    zobo committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    0b65485 View commit details
    Browse the repository at this point in the history