Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import version from pyxdf.py #16

Closed
cbrnr opened this issue Apr 25, 2019 · 4 comments
Closed

Import version from pyxdf.py #16

cbrnr opened this issue Apr 25, 2019 · 4 comments

Comments

@cbrnr
Copy link
Contributor

cbrnr commented Apr 25, 2019

In setup.py, we should not define the version number again, because we already do that in pyxdf.py.
@cboulay
Copy link
Contributor

cboulay commented Apr 25, 2019 •
edited
Loading

It needs to be in setup.py for pypi. Maybe we can get setup.py to read it from another file. Do you have any good examples of that?

https://packaging.python.org/guides/single-sourcing-package-version/

@cboulay
Copy link
Contributor

cboulay commented Apr 25, 2019

setuptools-scm looks interesting. Maybe I'll give that a try.

cboulay added a commit that referenced this issue Apr 26, 2019
@cboulay
Working on scm versioning. #16
28d79d4
@cboulay
Copy link
Contributor

cboulay commented Apr 26, 2019

Fixed in 28d79d4

@cboulay cboulay closed this as completed Apr 26, 2019
@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 26, 2019

Nice solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cboulay @cbrnr