Cereal override #23
Merged
Cereal override #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Discussed with David earlier and he approved merging this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up from David's cereal-override branch with a small (but quite obscure!) fix to use
std::declval<Archive&>in thehas_cereal_overrideprobe. This is necessary because the signatures ofnvp_adapter::applyandxdr::archivetake theirArchiveparameter by non-const, non-rval reference (Archive&), andstd::declval<Archive>alone resolves to anArchive&&which won't bind toArchive&. But if we callstd::declval<Archive&>it's defined to return anArchive&.(A lot of stackoverflow, C++ standard scrutiny and trial and error discovered this -- I would never have figured it out alone!)